WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
17191
HTML5: Client-side database queries should return values of type number
https://bugs.webkit.org/show_bug.cgi?id=17191
Summary
HTML5: Client-side database queries should return values of type number
Kimmo Kinnunen
Reported
2008-02-06 04:05:53 PST
HTML5 Client-side database storage spec doesn't seem to say what type of return values queries should return. However, it'd make sense in some cases to get numbers as results of queries. Currently DB queries return only string values. SQLite doesn't enforce the column types, but at least it'd be useful to get the same type out as was put in.
Attachments
Makes inserted numbers come back as numbers (not as strings)
(8.33 KB, patch)
2008-02-06 04:27 PST
,
Kimmo Kinnunen
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2008-02-06 04:27:48 PST
Created
attachment 18958
[details]
Makes inserted numbers come back as numbers (not as strings)
Timothy Hatcher
Comment 2
2008-02-06 07:20:43 PST
Comment on
attachment 18958
[details]
Makes inserted numbers come back as numbers (not as strings) This looks good. No need for the braces around the for loop now. Remove them to match our style. for (int i = 0; i < columnCount; i++) { - // FIXME: Look at the column type? - rows->addResult(statement.getColumnText(i)); + rows->addResult(statement.getColumnValue(i)); }
Oliver Hunt
Comment 3
2008-02-07 22:51:50 PST
Will land this shortly, just incorporating tim's comment and building, etc.
Oliver Hunt
Comment 4
2008-02-07 23:22:08 PST
Landed
r30087
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug