Bug 17165 - Widget needs to subclass wxWindow, not wxScrolledWindow
Summary: Widget needs to subclass wxWindow, not wxScrolledWindow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-03 11:24 PST by Kevin Watters
Modified: 2008-02-03 13:12 PST (History)
0 users

See Also:

Attachments
Widget subclasses wxWindow instead of wxScrolledWindow (17.45 KB, patch)
2008-02-03 11:25 PST, Kevin Watters 		kevino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2008-02-03 11:24:32 PST 
Widget (and therefore ScrollView) currently inherits from wxScrolledWindow, a class intended to be a simple container for a panel whose virtual area exceeds that of a window on screen.

Since WebKit provides Javascript with means to enable and disable scrollbars as well as scroll the page, Widget needs to perform scrolling at a lower level than wxScrolledWindow.

This results in scrollbars that can't be disabled and difficulty scrolling smoothly, among other issues.
Comment 1 Kevin Watters 2008-02-03 11:25:18 PST 
Created attachment 18886 [details]
Widget subclasses wxWindow instead of wxScrolledWindow
Comment 2 Kevin Ollivier 2008-02-03 13:09:01 PST 
Comment on attachment 18886 [details]
Widget subclasses wxWindow instead of wxScrolledWindow

This is a much needed fix that stops us from rendering areas outside of the page and works great in my testing. Thanks!
Comment 3 Kevin Ollivier 2008-02-03 13:12:22 PST 
Landed in r29948. Thanks! :)