RESOLVED FIXED 17165
Widget needs to subclass wxWindow, not wxScrolledWindow 
https://bugs.webkit.org/show_bug.cgi?id=17165
Summary Widget needs to subclass wxWindow, not wxScrolledWindow
Kevin Watters
Reported 2008-02-03 11:24:32 PST
Widget (and therefore ScrollView) currently inherits from wxScrolledWindow, a class intended to be a simple container for a panel whose virtual area exceeds that of a window on screen. Since WebKit provides Javascript with means to enable and disable scrollbars as well as scroll the page, Widget needs to perform scrolling at a lower level than wxScrolledWindow. This results in scrollbars that can't be disabled and difficulty scrolling smoothly, among other issues.
Attachments
Widget subclasses wxWindow instead of wxScrolledWindow (17.45 KB, patch)
2008-02-03 11:25 PST, Kevin Watters 		kevino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Watters
Comment 1 2008-02-03 11:25:18 PST
Created attachment 18886 [details] Widget subclasses wxWindow instead of wxScrolledWindow
Kevin Ollivier
Comment 2 2008-02-03 13:09:01 PST
Comment on attachment 18886 [details] Widget subclasses wxWindow instead of wxScrolledWindow This is a much needed fix that stops us from rendering areas outside of the page and works great in my testing. Thanks!
Kevin Ollivier
Comment 3 2008-02-03 13:12:22 PST
Landed in r29948. Thanks! :)
Note You need to log in before you can comment on or make changes to this bug.