Bug 17130 – Stop Windows from eating crashes in timer callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit wx

[Kevin Ollivier]

This issue was already fixed in r28500 of the Windows port, and we are applying the fix to the wx port. In fact, since wxWidgets internally uses the very callback mechanism that is the source of this problem, we are using the SharedTimerWin.cpp implementation for our Windows timer. 

Initial fix coded up by Kevin Watters, with minor tweaks by me.

[Kevin Ollivier]

Created attachment 18839 [details]
Move to SharedTimerWin.cpp impl. to fix callback problem

[Adam Roben (:aroben)]

Comment on attachment 18839 [details]
Move to SharedTimerWin.cpp impl. to fix callback problem

 #include "Page.h"
+#if PLATFORM(WIN)
 #include "PluginViewWin.h"
+#endif
 #include "SystemTime.h"
 #include "Widget.h"
 #include <wtf/Assertions.h>
+#if PLATFORM(WX)
+#include <wx/wx.h>
+#endif
 #include <windows.h>

Please put any #ifdef'd headers in their own paragraph after all the non-#ifdef'd headers. That's the style we use in most files like this.

+
 namespace WebCore {

This extra newline isn't needed.

r=me, even if these issues aren't fixed. It would be nice to fix these before committing though.

[Kevin Ollivier]

Landed in r29937. Thanks!