Bug 17118 - kjs_navigator.cpp should be re-written to be less crazy
Summary: kjs_navigator.cpp should be re-written to be less crazy
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-31 09:13 PST by Eric Seidel (no email)
Modified: 2009-01-03 13:44 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-01-31 09:13:49 PST 
kjs_navigator.cpp should be re-written to be less crazy

kjs_navigator uses a complicated/hacky memory management scheme and thus I bet leaks in some cases.

Better would be for PluginBase to hold a reference to some PluginInfoCache static.  When the PluginInfoCache ref count drops to 0, it can clear its caches.  Those caches can use Vector<OwnPtr> to avoid ever leaking.

This could/should also be re-written to use the bindings autogen system.  Thus Navigator would become a normal RefCounted class, and Navigator.idl would take care of all the details.
Comment 1 David Kilzer (:ddkilzer) 2009-01-02 11:30:10 PST 
Can this bug be closed?  I know Navigator.h/cpp/idl were created a while ago, and the plugin code has undergone many refactorings since this was filed.