Bug 17085 – REGRESSION (r29839): All remote fonts are treated as SVG fonts (Acid3 Ahem test font no longer loads)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Acid3 Ahem test font no longer loads

the @font-face in acid3 used to work.  But now I just see lots of logs to the console (possibly related to other failed @font-face loads for SVG font testing):

This is the CSS:
  @font-face { font-family: "AcidAhemTest"; src: url(font.ttf); }
  map::after { position: absolute; top: 20px; left: 640px; content: "X"; background: fuchsia; color: white; font: 20px/1 AcidAhemTest; }

[Eric Seidel (no email)]

These are the logs:

ERROR: unable to initialize with font (null) at not known
(/Stuff/Projects/WebKit/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:147 void WebCore::SimpleFontData::platformInit())
ERROR: Corrupt font detected, using (null) in place of (null) located at "not known".
(/Stuff/Projects/WebKit/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:154 void WebCore::SimpleFontData::platformInit())
ERROR: failed to set up font, using system font ?kx?
(/Stuff/Projects/WebKit/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:161 void WebCore::SimpleFontData::platformInit())

[Eric Seidel (no email)]

I'm not certain if WebKit changed or if Acid3 changed.  Either way, I don't think we've shipped a version of WebKit which supported this @font-face, so I'm not going to mark this a regression.

All font data is parsed as SVG.

<rdar://problem/5714136>

The problem is CSSFontFaceSource::getFontData() always going the SVG path first (thus creating an SVG document with garbage data, that ends up not containing any fonts). It should only take that path for SVG data.

Created attachment 18787 [details]
Patch

[Dave Hyatt]

Comment on attachment 18787 [details]
Patch

r=me

How was this not caught by regression tests?

(In reply to comment #7)
> (From update of attachment 18787 [details] [edit])
> r=me
> 
> How was this not caught by regression tests?
> 

Whoever implemented @font-face did not check in regression tests for remote (or any) fonts :-)

Fixed in <http://trac.webkit.org/projects/webkit/changeset/29864>.