Bug 17067 - eliminate attributes parameter from JSObject::put for speed/clarity
Summary: eliminate attributes parameter from JSObject::put for speed/clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on: 17094
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-29 10:15 PST by Darin Adler
Modified: 2008-02-23 21:01 PST (History)
2 users (show)

See Also:


Attachments
work in progress (77.44 KB, patch)
2008-01-29 10:19 PST, Darin Adler
no flags Details | Formatted Diff | Diff
patch (passes all regression tests, but ignores attributes in put call in C API) (68.09 KB, patch)
2008-02-08 01:50 PST, Darin Adler
no flags Details | Formatted Diff | Diff
patch (83.56 KB, patch)
2008-02-23 12:59 PST, Darin Adler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-01-29 10:15:30 PST
I realized that JSObject::put doesn't really need an attributes parameter, so I'm working to get rid of it.
Comment 1 Darin Adler 2008-01-29 10:19:03 PST
Created attachment 18764 [details]
work in progress
Comment 2 Darin Adler 2008-02-08 01:50:26 PST
Created attachment 19001 [details]
patch (passes all regression tests, but ignores attributes in put call in C API)
Comment 3 Darin Adler 2008-02-09 07:21:15 PST
This is *so* close to being ready to review. The remaining issue is what we should do about the C API. Do we want to give the public put call the ability to assign attributes, and if so, how should we do this while preserving the rest of the semantics? Maybe it should do some combination of getDirect, putDirect, and put?
Comment 4 Darin Adler 2008-02-16 07:16:30 PST
Geoff, I'd like to land this.

What do you think we should do about the attribute argument to JSObjectSetProperty? I think we discussed it but I forgot what we decided.
Comment 5 Darin Adler 2008-02-23 12:59:44 PST
Created attachment 19307 [details]
patch
Comment 6 Anders Carlsson 2008-02-23 17:02:35 PST
Comment on attachment 19307 [details]
patch

r=me with the change we discussed on IRC
Comment 7 Darin Adler 2008-02-23 21:01:49 PST
Committed revision 30534.