RESOLVED FIXED 17050
WIN32_LEAN_AND_MEAN fails to compile 
https://bugs.webkit.org/show_bug.cgi?id=17050
Summary WIN32_LEAN_AND_MEAN fails to compile
Tony Chang
Reported 2008-01-28 14:16:53 PST
The #define for WIN32_LEAN_AND_MEAN and _CRT_RAND_S should check for existing definitions because it could be defined project wide and conflict (or just be a duplicate #define). This is causing a problem for my build because I define these project wide.
Attachments
add #ifndef guards (1.59 KB, patch)
2008-01-28 14:17 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
extra include in webcore (874 bytes, patch)
2008-02-01 17:31 PST, Tony Chang 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2008-01-28 14:17:35 PST
Created attachment 18743 [details] add #ifndef guards
Darin Adler
Comment 2 2008-01-28 14:22:15 PST
Comment on attachment 18743 [details] add #ifndef guards Seems harmless. r=me
Tony Chang
Comment 3 2008-02-01 17:31:27 PST
Created attachment 18865 [details] extra include in webcore This is the only other change needed before being able to compile WebCore with WIN32_LEAN_AND_MEAN.
Eric Seidel (no email)
Comment 4 2008-02-02 15:16:22 PST
Comment on attachment 18743 [details] add #ifndef guards landed this first patch as r29941
Eric Seidel (no email)
Comment 5 2008-02-02 15:18:57 PST
Comment on attachment 18865 [details] extra include in webcore This also seems harmless. It's currently included by: platform/win/DragDataWin.cpp:#include <objidl.h> platform/win/WCDataObject.h:#include <objidl.h> Perhaps it should be moved to WebCorePrefix.h at some point.
Eric Seidel (no email)
Comment 6 2008-02-02 15:20:38 PST
Landed second patch as r29942.
Note You need to log in before you can comment on or make changes to this bug.