Bug 17031 - Patch to build with gcc 4.3
Summary: Patch to build with gcc 4.3
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-27 03:50 PST by Stephan Binner
Modified: 2008-01-29 00:57 PST (History)
1 user (show)

See Also:

Attachments
compilation fixes (3.98 KB, patch)
2008-01-27 03:51 PST, Stephan Binner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Binner 2008-01-27 03:50:38 PST 
FYI, I need these patches to make WebKit compile with current gcc 4.3 snapshots.
Comment 1 Stephan Binner 2008-01-27 03:51:41 PST 
Created attachment 18720 [details]
compilation fixes
Comment 2 Mark Rowe (bdash) 2008-01-27 18:05:48 PST 
The change to RenderThemeGtk.cpp does not look correct per our style guidelines.
Comment 3 Alexey Proskuryakov 2008-01-28 09:34:51 PST 
Please click Edit link to the right of the patch to mark it for review.

This patch needs a ChangeLog (see <http://webkit.org/coding/contributing.html> for more information), and of course, Mark's comment needs to be addressed, either by fixing the code, or by explaining why violating the guidelines is unavoidable in this case.
Comment 4 Alexey Proskuryakov 2008-01-29 00:57:32 PST 
The reporter has indicated (via e-mail) that he is no longer interested in this fix. Since gcc 4.3 is in pre-release state, I see no reason to keep tracking this issue, closing as WONTFIX.