17028 – REGRESSION: Buttons no longer wrap in table cell

Bug 17028 - REGRESSION: Buttons no longer wrap in table cell

Summary: REGRESSION: Buttons no longer wrap in table cell

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	523.x (Safari 3)
Hardware:	Mac OS X 10.4

Importance:	P1 Normal
Assignee:	Dave Hyatt

URL:	http://kakuro.cc/
Keywords:	HasReduction, InRadar, Regression

Depends on:
Blocks:

Reported:	2008-01-26 19:10 PST by Steve Nicolai
Modified:	2022-09-01 16:43 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Reduced test case (1.12 KB, text/html) 2008-01-26 19:11 PST, Steve Nicolai	no flags	Details
Always treat all form controls as replaced elements. (2.91 KB, patch) 2008-01-28 14:47 PST, Dave Hyatt	no flags	Details \| Formatted Diff \| Diff
More work in progress (7.43 KB, patch) 2008-01-29 10:56 PST, Dave Hyatt	no flags	Details \| Formatted Diff \| Diff
More work in progress (pretty much done). (11.06 KB, patch) 2008-01-29 20:02 PST, Dave Hyatt	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Nicolai 2008-01-26 19:10:41 PST

MacOS 10.4.11 with Safari/WebKit Version 3.0.4 (523.12.2)

WebKit 523 renders all six buttons on one line, extending beyond the table cell to the right.  WebKit 312 and Camino render the buttons as two rows of three buttons contained within the table cell.

Works on MacOS 10.3.9 with Safari/WebKit 1.3.2 (312.6).  Also works properly on Camino 1.5.4 on 10.4.11 (Intel)

Comment 1 Steve Nicolai 2008-01-26 19:11:44 PST

Created attachment 18714 [details]
Reduced test case

Comment 2 Dave Hyatt 2008-01-28 12:43:41 PST

I'll take this.

Comment 3 Dave Hyatt 2008-01-28 13:24:06 PST

This was a regression from Safari 2 to Safari 3 caused by the changes to calcInlinePrefWidths for this tables/images IE quirk.  Beth did the original code and I recently re-wrote it.  Both of our implementations have this bug. :)

Comment 4 Dave Hyatt 2008-01-28 13:24:32 PST

Actually these are buttons, so I may be wrong about the cause of this regression.

Comment 5 Alice Liu 2008-01-28 13:34:48 PST

please check radar for an update.

Comment 6 Alice Liu 2008-01-28 13:35:50 PST

<rdar://problem/5710787>

Comment 7 Dave Hyatt 2008-01-28 14:47:49 PST

Created attachment 18744 [details]
Always treat all form controls as replaced elements.

This is a preliminary patch.  I need to run the layout tests and do some testing to make sure that block-level form controls don't start malfunctioning with this patch.

Comment 8 Dave Hyatt 2008-01-29 10:56:46 PST

Created attachment 18765 [details]
More work in progress

Comment 9 Dave Hyatt 2008-01-29 20:02:54 PST

Created attachment 18788 [details]
More work in progress (pretty much done).

Comment 10 Gavin Sherlock 2009-09-19 01:52:05 PDT

The test case seems to render correctly now (in Safari 4.03, as well as r48518) - maybe this is fixed and can be closed?

Comment 11 Steve Nicolai 2009-09-19 08:04:36 PDT

This works for me with Safari 4.0.3(4531.9) as well.  Tested on PowerPC Tiger 10.4.11.

Comment 12 Ahmad Saleem 2022-09-01 16:43:48 PDT

All browsers (Safari Technology Preview 152, Firefox Nightly 106 and Chrome Canary 107) render this same and only difference is styling of button, which is subject to browsers to use system native or customised, so it is intended.

I am going to mark this as "RESOLVED CONFIGURATION CHANGED", please reopen if it is not fixed. Thanks!