Bug 17021 - REGRESSION: const is being ignored
Summary: REGRESSION: const is being ignored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2008-01-26 08:54 PST by Darin Adler
Modified: 2008-01-27 01:39 PST (History)
0 users

See Also:

Attachments
patch (118.48 KB, patch)
2008-01-26 08:58 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
same patch, rebased (114.99 KB, patch)
2008-01-27 01:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
same patch, rebased (114.85 KB, patch)
2008-01-27 01:03 PST, Darin Adler 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-01-26 08:54:35 PST 
Recent speed optimizations have entirely broken "const".

<rdar://problem/5657450>
Comment 1 Darin Adler 2008-01-26 08:58:00 PST 
Created attachment 18708 [details]
patch
Comment 2 Darin Adler 2008-01-27 01:02:42 PST 
Created attachment 18718 [details]
same patch, rebased
Comment 3 Darin Adler 2008-01-27 01:03:41 PST 
Created attachment 18719 [details]
same patch, rebased
Comment 4 Oliver Hunt 2008-01-27 01:29:24 PST 
Comment on attachment 18719 [details]
same patch, rebased

Can you test this in sunspider?

r=me
Comment 5 Darin Adler 2008-01-27 01:33:34 PST 
(In reply to comment #4)
> Can you test this in sunspider?

I did test it in SunSpider. It showed 1.003x slower (0.3%) with const support, although there was enough noise and that's that I'm not sure it's right. We might be able to shave it even closer with some more effort, but I think that is good enough that this should be landed as-is.
Comment 6 Darin Adler 2008-01-27 01:39:43 PST 
Committed revision 29818.