WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
17021
REGRESSION: const is being ignored
https://bugs.webkit.org/show_bug.cgi?id=17021
Summary
REGRESSION: const is being ignored
Darin Adler
Reported
2008-01-26 08:54:35 PST
Recent speed optimizations have entirely broken "const". <
rdar://problem/5657450
>
Attachments
patch
(118.48 KB, patch)
2008-01-26 08:58 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
same patch, rebased
(114.99 KB, patch)
2008-01-27 01:02 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
same patch, rebased
(114.85 KB, patch)
2008-01-27 01:03 PST
,
Darin Adler
oliver
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2008-01-26 08:58:00 PST
Created
attachment 18708
[details]
patch
Darin Adler
Comment 2
2008-01-27 01:02:42 PST
Created
attachment 18718
[details]
same patch, rebased
Darin Adler
Comment 3
2008-01-27 01:03:41 PST
Created
attachment 18719
[details]
same patch, rebased
Oliver Hunt
Comment 4
2008-01-27 01:29:24 PST
Comment on
attachment 18719
[details]
same patch, rebased Can you test this in sunspider? r=me
Darin Adler
Comment 5
2008-01-27 01:33:34 PST
(In reply to
comment #4
)
> Can you test this in sunspider?
I did test it in SunSpider. It showed 1.003x slower (0.3%) with const support, although there was enough noise and that's that I'm not sure it's right. We might be able to shave it even closer with some more effort, but I think that is good enough that this should be landed as-is.
Darin Adler
Comment 6
2008-01-27 01:39:43 PST
Committed revision 29818.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug