WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16966
Add benchmark/tests for querySelectorAll
https://bugs.webkit.org/show_bug.cgi?id=16966
Summary
Add benchmark/tests for querySelectorAll
David Smith
Reported
2008-01-21 22:37:39 PST
weinig and I still owe a blog post on qSA, and everyone loves easy to interpret benchmark charts, so I modified the mootools test/benchmark in the following ways: 1) more iterations, so we can actually see variance 2) try/catch around each test so that one exception won't break every test after it 3) removed tests of selectors that webkit doesn't implement yet, so as to not throw off the resulting total 4) added a column for the native querySelectorAll implementation
Attachments
the aforementioned benchmark
(276.74 KB, patch)
2008-01-21 22:40 PST
,
David Smith
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Smith
Comment 1
2008-01-21 22:40:17 PST
Created
attachment 18598
[details]
the aforementioned benchmark
David Smith
Comment 2
2008-01-21 22:43:45 PST
Adding a URL to a copy of it on my site.
Adam Roben (:aroben)
Comment 3
2008-01-22 06:53:04 PST
Comment on
attachment 18598
[details]
the aforementioned benchmark What's the license covering the SlickSpeed benchmark? I think we'd need a LICENSE file in the slickspeed directory making this clear. I also wonder whether this would be better placed in the WebKitTools directory?
Darin Adler
Comment 4
2008-01-22 10:18:30 PST
Comment on
attachment 18598
[details]
the aforementioned benchmark Seems OK to put this on the website. It'd be a little better if there was something that indicated what was changed from the original slickspeed test. Presumably there's a reason we're hosting our own copy and it would be best to be clear on why.
David Smith
Comment 5
2008-01-22 10:19:28 PST
(In reply to
comment #4
)
> (From update of
attachment 18598
[details]
[edit]) > Seems OK to put this on the website. > > It'd be a little better if there was something that indicated what was changed > from the original slickspeed test. Presumably there's a reason we're hosting > our own copy and it would be best to be clear on why. >
Sure. I'll add an explanatory paragraph about the changes before committing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug