Bug 16931 - Page text is shifted to right (nested HTML comments)
Summary: Page text is shifted to right (nested HTML comments)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://eye.columbiaspectator.com/
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-18 19:50 PST by Mike
Modified: 2009-11-15 00:41 PST (History)
6 users (show)

See Also:


Attachments
The page which does not render properly (382.22 KB, application/x-webarchive)
2008-01-18 19:54 PST, Mike
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike 2008-01-18 19:50:19 PST
I do not know anything about the underlying code of this site, but http://eye.columbiaspectator.com/ renders text that should be in the center of the page far over to the right. I apologize for not being able to be more specific, but I've attached a webarchive of the problem. The page renders fine in Firefox 3.0b2.
Comment 1 Mike 2008-01-18 19:54:41 PST
Created attachment 18538 [details]
The page which does not render properly

The text is shifted to the right, when it should be in the center.
Comment 2 Oliver Hunt 2008-01-18 20:02:26 PST
This also misrenders in the same way in Opera -- are we missing a quirk of some kind?

There doesn't appear to be in UA sniffing at play either (changing to an ffx ua, and viewing the content saved by ffx produced th same bug :-/)
Comment 3 David Kilzer (:ddkilzer) 2008-01-19 12:22:44 PST
Same issue occurs with Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.11 (8S165), so this is not a regression.

Comment 4 David Kilzer (:ddkilzer) 2008-01-19 13:03:17 PST
The problem is that the HTML content of the page has a nested comment (<!-- tags <!-- comment --> tags -->).  If the "<!-- comment -->" in the center is removed, the page renders as expected.

You can see the stray "-->" that is rendered with Safari above "ABOUT THE EYE" in the sidebar.

What does HTML5 say about nested comments?  Should the parser track the nested comments and try to line them up, or should the first "-->" effectively end any current comment regardless of the "match" level?

Comment 5 Alexey Proskuryakov 2008-01-28 10:16:36 PST
This site also misrenders in IE7, so looks like Firefox is the only browser it works with.

I think it's just "SGML comment parsing" that's still not fixed in Firefox: <http://ln.hixie.ch/?start=1137799947&count=1>. We were matching Firefox for a while (in Safari 2.0.3), and it was causing problems with other sites.

Moving to Evangelism.
Comment 6 Robert Blaut 2009-11-15 00:41:11 PST
I've checked the reported site with WebKit 4.0.4 (6531.21.10, r50918) and I found no problem with the site now. 

The site is rebuilt and works fine in WebKit now.

I close this bug as resolved fixed an evangelism bug.