Bug 16908 - run-webkit-tests complains about missing FindSafari.exe
Summary: run-webkit-tests complains about missing FindSafari.exe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-17 11:27 PST by Alexey Proskuryakov
Modified: 2008-01-17 11:52 PST (History)
1 user (show)

See Also:

Attachments
proposed fix (1.33 KB, patch)
2008-01-17 11:30 PST, Alexey Proskuryakov 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2008-01-17 11:27:03 PST 
When in debug configuration, webkitdirs.pm should use FindSafari_debug.exe,

Patch forthcoming.
Comment 1 Alexey Proskuryakov 2008-01-17 11:30:12 PST 
Created attachment 18505 [details]
proposed fix
Comment 2 Adam Roben (:aroben) 2008-01-17 11:46:17 PST 
Comment on attachment 18505 [details]
proposed fix

r=me

I think overall it would be better to make FindSafari.vcproj only have one build configuration, and to never put the suffix on the filename.
Comment 3 Alexey Proskuryakov 2008-01-17 11:52:03 PST 
Committed revision 29589.

> I think overall it would be better to make FindSafari.vcproj only have one
> build configuration, and to never put the suffix on the filename.

I agree, but not enthusiastically enough to think it through and make a new fix :-)