WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16908
run-webkit-tests complains about missing FindSafari.exe
https://bugs.webkit.org/show_bug.cgi?id=16908
Summary
run-webkit-tests complains about missing FindSafari.exe
Alexey Proskuryakov
Reported
2008-01-17 11:27:03 PST
When in debug configuration, webkitdirs.pm should use FindSafari_debug.exe, Patch forthcoming.
Attachments
proposed fix
(1.33 KB, patch)
2008-01-17 11:30 PST
,
Alexey Proskuryakov
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2008-01-17 11:30:12 PST
Created
attachment 18505
[details]
proposed fix
Adam Roben (:aroben)
Comment 2
2008-01-17 11:46:17 PST
Comment on
attachment 18505
[details]
proposed fix r=me I think overall it would be better to make FindSafari.vcproj only have one build configuration, and to never put the suffix on the filename.
Alexey Proskuryakov
Comment 3
2008-01-17 11:52:03 PST
Committed revision 29589.
> I think overall it would be better to make FindSafari.vcproj only have one > build configuration, and to never put the suffix on the filename.
I agree, but not enthusiastically enough to think it through and make a new fix :-)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug