Bug 16884 - Circular Dependency between PluginPackageWin and PluginDatabaseWin
Summary: Circular Dependency between PluginPackageWin and PluginDatabaseWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-15 11:18 PST by Rodney Dawes
Modified: 2008-01-16 13:16 PST (History)
1 user (show)

See Also:

Attachments
Patch to remove circular dependency (4.73 KB, patch)
2008-01-15 11:19 PST, Rodney Dawes 		no flags Details | Formatted Diff | Diff
Updated patch to clean up as per comments (6.23 KB, patch)
2008-01-15 15:11 PST, Rodney Dawes 		jhoneycutt: review+
Details | Formatted Diff | Diff
Updated patch to move constants into fuction and add punctuation to ChangeLog (6.26 KB, patch)
2008-01-16 07:37 PST, Rodney Dawes 		jhoneycutt: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Dawes 2008-01-15 11:18:26 PST 
There is a circular dependency between these too classes. The attached patch removes this dependency by moving the isPluginBlacklisted class method to a static internal method in PluginPackageWin.cpp, as the method does not appear to require any other parts of the PluginDatabaseWin code.
Comment 1 Rodney Dawes 2008-01-15 11:19:11 PST 
Created attachment 18460 [details]
Patch to remove circular dependency
Comment 2 Jon Honeycutt 2008-01-15 12:21:58 PST 
(In reply to comment #1)
> Created an attachment (id=18460) [edit]
> Patch to remove circular dependency
> 
Looks good, but I think you could make isPluginBlacklisted a private member method of PluginPackageWin. Then you could remove the getFileVersion method, as this is its only caller.
Comment 3 Rodney Dawes 2008-01-15 15:11:50 PST 
Created attachment 18462 [details]
Updated patch to clean up as per comments
Comment 4 Jon Honeycutt 2008-01-15 17:51:23 PST 
Comment on attachment 18462 [details]
Updated patch to clean up as per comments

I think your ChangeLog entry could use some punctuation. I think you could also put the Silverlight version constants inside the function body. Otherwise looks great. Thanks for working on this!

r=me
Comment 5 Rodney Dawes 2008-01-16 07:37:12 PST 
Created attachment 18472 [details]
Updated patch to move constants into fuction and add punctuation to ChangeLog
Comment 6 Jon Honeycutt 2008-01-16 13:15:45 PST 
Comment on attachment 18472 [details]
Updated patch to move constants into fuction and add punctuation to ChangeLog

Submitted in r29532. Thanks!