RESOLVED FIXED 16884
Circular Dependency between PluginPackageWin and PluginDatabaseWin 
https://bugs.webkit.org/show_bug.cgi?id=16884
Summary Circular Dependency between PluginPackageWin and PluginDatabaseWin
Rodney Dawes
Reported 2008-01-15 11:18:26 PST
There is a circular dependency between these too classes. The attached patch removes this dependency by moving the isPluginBlacklisted class method to a static internal method in PluginPackageWin.cpp, as the method does not appear to require any other parts of the PluginDatabaseWin code.
Attachments
Patch to remove circular dependency (4.73 KB, patch)
2008-01-15 11:19 PST, Rodney Dawes 		no flags
DetailsFormatted DiffDiff
Updated patch to clean up as per comments (6.23 KB, patch)
2008-01-15 15:11 PST, Rodney Dawes 		jhoneycutt: review+
DetailsFormatted DiffDiff
Updated patch to move constants into fuction and add punctuation to ChangeLog (6.26 KB, patch)
2008-01-16 07:37 PST, Rodney Dawes 		jhoneycutt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2008-01-15 11:19:11 PST
Created attachment 18460 [details] Patch to remove circular dependency
Jon Honeycutt
Comment 2 2008-01-15 12:21:58 PST
(In reply to comment #1) > Created an attachment (id=18460) [edit] > Patch to remove circular dependency > Looks good, but I think you could make isPluginBlacklisted a private member method of PluginPackageWin. Then you could remove the getFileVersion method, as this is its only caller.
Rodney Dawes
Comment 3 2008-01-15 15:11:50 PST
Created attachment 18462 [details] Updated patch to clean up as per comments
Jon Honeycutt
Comment 4 2008-01-15 17:51:23 PST
Comment on attachment 18462 [details] Updated patch to clean up as per comments I think your ChangeLog entry could use some punctuation. I think you could also put the Silverlight version constants inside the function body. Otherwise looks great. Thanks for working on this! r=me
Rodney Dawes
Comment 5 2008-01-16 07:37:12 PST
Created attachment 18472 [details] Updated patch to move constants into fuction and add punctuation to ChangeLog
Jon Honeycutt
Comment 6 2008-01-16 13:15:45 PST
Comment on attachment 18472 [details] Updated patch to move constants into fuction and add punctuation to ChangeLog Submitted in r29532. Thanks!
Note You need to log in before you can comment on or make changes to this bug.