Bug 16778 – Language specific bindings cannot cache/reuse previously created Instances and RuntimeObjects

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Goddard]

The static Instance::createRuntimeBinding* functions currently return a new Instance/RuntimeObjectImp for every request.  This means that JSObject equality will not work, and also creates unnecessary objects.  For the Qt port at least, we rely on object equality for connecting/disconnecting signals and slots.

[Michael Goddard]

Created attachment 18320 [details]
Proposed patch (adds caching for Qt bindings)

[Michael Goddard]

Hmm.. patch (id 18320) not quite complete - doesn't handle the case when an Instance has a ref from someone apart from the RuntimeObjectImp (so the RuntimeObjectImp can be deleted without the cache noticing, and reuses an old pointer).  New patch soon.

[Michael Goddard]

Created attachment 18337 [details]
Updated patch - better Qt RuntimeObjectImp lifetime management

[Anders Carlsson]

Comment on attachment 18337 [details]
Updated patch - better Qt RuntimeObjectImp lifetime management

>+    virtual BindingLanguage getBindingLanguage() const {return CLanguage;}

Need spaces after the open brace and before the close brace.

>+    virtual BindingLanguage getBindingLanguage() const {return JavaLanguage;}

Here too.

>+    virtual BindingLanguage getBindingLanguage() const {return ObjectiveCLanguage;}

Here too.

>+    virtual BindingLanguage getBindingLanguage() const {return QtLanguage;}

And here :)

This looks great otherwise, r=me.

[Mark Rowe (bdash)]

Landed in r29447 with tweaks to not break the Mac build.