WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16732
Update svn:ignore properties for autotools build
https://bugs.webkit.org/show_bug.cgi?id=16732
Summary
Update svn:ignore properties for autotools build
Rodney Dawes
Reported
2008-01-04 09:57:45 PST
The autotools build creates several additional files and directories which need to be ignored by svn status and other svn commands.
Attachments
Patch for using to update svn:ignore properties
(11.90 KB, patch)
2008-01-04 10:01 PST
,
Rodney Dawes
alp
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rodney Dawes
Comment 1
2008-01-04 10:01:31 PST
Created
attachment 18272
[details]
Patch for using to update svn:ignore properties Since svn:ignore changes are not applyable to the repository with the patch command, I had to pull the properties out into files which the properties then get set by reading. After applying this patch, you will need to run the following command, to actually change the svn:ignore properties, and subsequently delete the .svnignore files which are only useful for this process: for i in `find . -name .svnignore`; do svn propset svn:ignore `dirname $i` -F $i; rm -f $i; done This command will set the svn:ignore properties based on the contents of the .svnignore files, and then delete those files.
Mark Rowe (bdash)
Comment 2
2008-01-04 10:03:44 PST
Most of this can be taken care of by fixing the autotools build to store it's build output into WebKitBuild like the other ports do. This will still leave configure, GNUmakefile, and a few others that will need to be ignored, but the list will be much smaller. I would much prefer to see that fixed rather than having to sprinkle these properties all over the source tree.
Alp Toker
Comment 3
2008-01-11 08:35:12 PST
I think we should add the toplevel ignores sufficient to give a clean svn stat when building out-of-tree. Maintaining all the ignores on each subdirectory as new code and modules are added is too much work. ie. a subset of these: --- .svnignore (revision 0) +++ .svnignore (revision 0) @@ -0,0 +1,36 @@ +.deps +.libs +DerivedSources +Programs +WebKitBuild +icu +iconv +libxml +libxslt +zlib +WebKitSupportLibrary.zip +INSTALL +GNUmakefile +GNUmakefile.in +README +aclocal.m4 +aconfig.h +autom4te-2.5x.cache +autom4te.cache +compile +config.guess +config.log +config.status +config.sub +configure +depcomp +install-sh +libtool +missing +ltmain.sh +stamp-h1 +stamp-webkit-marshal.h
Alp Toker
Comment 4
2008-01-11 08:36:52 PST
Comment on
attachment 18272
[details]
Patch for using to update svn:ignore properties Could you reduce this to only cover the minimum necessary as I described in my previous comment? Good way to check this is mkdir release && cd release && ../autogen.sh, then see what SVN stat says. Thanks
Alp Toker
Comment 5
2008-01-16 04:09:35 PST
Subset of these ignores landed in
r29530
. Re-open the bug if you think there need to be more ignores. I skipped README/INSTALL since it's conceivable someone will write these eventually.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug