Bug 16712 - change StringImpl to take and return PassRefPtr instead of raw pointers
Summary: change StringImpl to take and return PassRefPtr instead of raw pointers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-02 14:20 PST by Darin Adler
Modified: 2008-01-02 17:27 PST (History)
0 users

See Also:

Attachments
patch (74.72 KB, patch)
2008-01-02 15:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (75.89 KB, patch)
2008-01-02 15:41 PST, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-01-02 14:20:01 PST 
As I mentioned in my mail about strings, the next step in reforming string classes is to make StringImpl be consistent about use of PassRefPtr instead of raw pointers.
Comment 1 Darin Adler 2008-01-02 15:02:53 PST 
Created attachment 18241 [details]
patch
Comment 2 Darin Adler 2008-01-02 15:41:11 PST 
Created attachment 18242 [details]
patch
Comment 3 Anders Carlsson 2008-01-02 16:21:12 PST 
Comment on attachment 18242 [details]
patch

r=me with some minor changes discussed on IRC
Comment 4 Darin Adler 2008-01-02 17:27:03 PST 
r29098