Bug 16700 - Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
Summary: Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 12111
Blocks:
  Show dependency tree / graph
 
Reported: 2008-01-01 15:36 PST by David Kilzer (:ddkilzer)
Modified: 2008-01-01 16:38 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.90 KB, patch)
2008-01-01 15:55 PST, David Kilzer (:ddkilzer) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2008-01-01 15:36:00 PST 
The fix for Bug 12111 was not fully correct.  The return value of -[NSFileManager fileExistsAtPath:isDirectory:] should be checked.

See Bug 12111 Comment #8.
Comment 1 David Kilzer (:ddkilzer) 2008-01-01 15:55:06 PST 
Created attachment 18228 [details]
Patch v1

Use the return value of -[NSFileManager fileExistsAtPath:isDirectory:] and clean up code for WebKit style (remove extraneous curly braces in if/else statements).
Comment 2 mitz 2008-01-01 16:09:44 PST 
Comment on attachment 18228 [details]
Patch v1

r=me
Comment 3 David Kilzer (:ddkilzer) 2008-01-01 16:38:32 PST 
Committed revision 29072.