Bug 16692 – Acid3 expects \u escapes to work in data: urls

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Acid3 expects \u escapes to work in data: urls

We seem to be escaping \'s as /'s before trying \u escapes.

See test case.  This should be an easy fix.

Firefox and opera pass this test, I have not tried WinIE.

[Eric Seidel (no email)]

Created attachment 18222 [details]
test case

[Eric Seidel (no email)]

I expect this is the problem right here:

KURL::init()

    // for compatibility with Win IE, we must treat backslashes as if they were slashes, as long as we're not dealing with the javascript: schema
    DeprecatedString substitutedRelative;
    bool shouldSubstituteBackslashes = relative.contains('\\') && !relative.startsWith("javascript:", false);
    if (shouldSubstituteBackslashes) {
        substitutedRelative = substituteBackslashes(relative);
    }

That check is obviously failing (or not getting hit for this code path).

[Eric Seidel (no email)]

Created attachment 18223 [details]
Don't replace \ with / in data: urls

 LayoutTests/ChangeLog                              |   10 ++++++++++
 .../loader/url-data-replace-backslash-expected.txt |    1 +
 .../fast/loader/url-data-replace-backslash.html    |   13 +++++++++++++
 WebCore/ChangeLog                                  |   12 ++++++++++++
 WebCore/platform/KURL.cpp                          |    5 ++---
 5 files changed, 38 insertions(+), 3 deletions(-)

[Alexey Proskuryakov]

Comment on attachment 18223 [details]
Don't replace \ with / in data: urls

r=me

\ No newline at end of file

Please add one :)

[Eric Seidel (no email)]

r29061

[Alexey Proskuryakov]

*** Bug 11464 has been marked as a duplicate of this bug. ***