RESOLVED FIXED 16691
Use real JS objects for the rest of the DOMExceptions (EventException, RangeException, etc) 
https://bugs.webkit.org/show_bug.cgi?id=16691
Summary Use real JS objects for the rest of the DOMExceptions (EventException, RangeE...
Sam Weinig
Reported 2008-01-01 01:24:13 PST
Now that we are throwing a custom JS object for the core exceptions, and the base work is done, we should be throwing the different objects for the different types of exceptions.
Attachments
patch (116.50 KB, patch)
2008-01-01 15:59 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2008-01-01 15:59:48 PST
Created attachment 18229 [details] patch This patch makes JS objects for all the Exception types, and uses a shared base class for the implementation. I have tests for the EventException, RangeException, and XPathExceptions, and am still working on making SVG and XHR tests, but I thought I would put this up for review while I figured out how to do that, in order to make sure that I was on the right track with it.
Eric Seidel (no email)
Comment 2 2008-01-01 16:41:24 PST
Comment on attachment 18229 [details] patch The approach looks sane. My impression was you were going to add more tests before we did a real review. You also just noted over IRC that the XHR exceptions were different from expected.
Darin Adler
Comment 3 2008-01-01 19:40:55 PST
Comment on attachment 18229 [details] patch I'm really worried that the named constants that are members of the classes are not the same values as the same-named constants in the JavaScript language binding. Otherwise, I love this. r=me
Sam Weinig
Comment 4 2008-01-01 21:47:11 PST
Landed in r29073.
Note You need to log in before you can comment on or make changes to this bug.