RESOLVED FIXED 16674
[GTK] run-launcher sets wrong LD_LIBRARY_PATH 
https://bugs.webkit.org/show_bug.cgi?id=16674
Summary [GTK] run-launcher sets wrong LD_LIBRARY_PATH
Luca Bruno
Reported 2007-12-30 02:23:25 PST
Hello, the run-launcher uses WebKitBuild/{build} as LD_LIBRARY_PATH instead of WebKitBuild/{build}/lib. Maybe this issue is only for GtkLauncher and other ports don't need /lib?
Attachments
use /lib (999 bytes, patch)
2007-12-30 02:27 PST, Luca Bruno 		no flags
DetailsFormatted DiffDiff
use catdir (1.67 KB, patch)
2007-12-30 11:30 PST, Luca Bruno 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luca Bruno
Comment 1 2007-12-30 02:27:25 PST
Created attachment 18185 [details] use /lib Very simple patch.
David Kilzer (:ddkilzer)
Comment 2 2007-12-30 08:28:53 PST
This needs to be reviewed by a Qt developer to make sure this doesn't break launching QtLauncher. It may also be wise to start using the catdir() function from the File::Spec Perl module to concatenate paths.
Luca Bruno
Comment 3 2007-12-30 11:30:08 PST
Created attachment 18195 [details] use catdir I'm not able to run Qt if LD_LIBRARY_PATH is not set to /lib currently, but i don't use Qt at all.
Darin Adler
Comment 4 2008-01-01 01:18:08 PST
Comment on attachment 18195 [details] use catdir Even though I'm no expert on the details here, this looks fine to me. r=me
Alp Toker
Comment 5 2008-01-02 04:56:52 PST
Landed in r29081.
Note You need to log in before you can comment on or make changes to this bug.