Bug 16590 – Solaris OS compile fix

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Holger Freyther]

kjs currently does not compile on Solaris OS. We have fix from Adrian de Groot in the QtWebkit branch, this patch is also in the KDE version of kjs.

[Holger Freyther]

Created attachment 18080 [details]
Solaris Compile fix from Adrian de Groot

Compile fix for Solaris OS and non GNU compilers.

[Eric Seidel (no email)]

Comment on attachment 18080 [details]
Solaris Compile fix from Adrian de Groot

Looks fine.  strange that: isinf would use one NaN test and isfinite would use a different one.  Perhaps we should fix that before landing.  !isNan() is clearer.

[Maciej Stachowiak]

It would be better if these were written as inline functions, not #defines:

+#if PLATFORM(SOLARIS_OS) && COMPILER(GCC)
+#include <ieeefp.h>
+#if !defined(isfinite)
+#define isfinite(x) (finite(x) && !isnand(x))
+#endif
+#if !defined(isinf)
+#define isinf(x) (!finite(x) && (x == x))
+#endif
+#if !defined(signbit)
+#define signbit(x) (x < 0.0)
+#endif
+#endif
+

Please fix when landing.

[Mark Rowe (bdash)]

Does SOLARIS_OS need the _OS suffix?  The reason for the _OS suffix on WIN is to distinguish between the base platform and the higher-level APIs.  Does Solaris also refer to a higher-level environment to which WebKit may one day be ported?  My understanding was that it runs X with GNOME, thus the Gtk or Qt ports would provide this higher layer.

[Darin Adler]

Committed revision 29454.

I considered all the comments in this bug.

The implementation of signbit is definitely incorrect, so I added a FIXME.