RESOLVED FIXED 16577
Merge Cairo enhancements from Apollo project 
https://bugs.webkit.org/show_bug.cgi?id=16577
Summary Merge Cairo enhancements from Apollo project
Brent Fulgham
Reported 2007-12-22 20:28:03 PST
The attached patch extends the Cairo backend, namely providing the missing implementations for: * GraphicsContext::clipOut(const Path&) * GraphicsContext::clipOut(const IntRect&) * GraphicsContext::clipOutEllipseInRect(const IntRect&) * GraphicsContext::fillRoundedRect
Attachments
Patch to flesh-out the Cairo implementation (15.63 KB, patch)
2007-12-22 20:29 PST, Brent Fulgham 		alp: review-
DetailsFormatted DiffDiff
Cairo graphics fixes (6.47 KB, patch)
2007-12-23 01:15 PST, Alp Toker 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2007-12-22 20:29:12 PST
Created attachment 18064 [details] Patch to flesh-out the Cairo implementation Patch extends the Cairo implementation with additional functionality missing in the current implementation.
Eric Seidel (no email)
Comment 2 2007-12-22 20:38:26 PST
Comment on attachment 18064 [details] Patch to flesh-out the Cairo implementation This patch will need to update copyrights as well in order to be considered for landing.
Mark Rowe (bdash)
Comment 3 2007-12-22 20:43:49 PST
The changes in platform/graphics/Image.cpp shouldn't be there. They were removed from trunk in r27060. I also don't like the addition of the many PLATFORM(APOLLO) ifdefs when that port is not present in SVN. The code these are being added to is virtually free of ifdef's at present, which is the way we prefer things to be.
Alp Toker
Comment 4 2007-12-22 21:59:33 PST
Eric: There is no problem with the copyright headers here, everything's in order. We will want to boil this patch down to remove the platform-specific parts for now. If we go ahead with a Cairo/Win port, this code will go elsewhere anyway, not in GraphicsContextCairo. The hasAlpha() change is also obsolete IIRC. I'll continue to investigate this patch and verify the correctness of the substantive changes. Thanks!
Alp Toker
Comment 5 2007-12-22 22:00:24 PST
Comment on attachment 18064 [details] Patch to flesh-out the Cairo implementation r- for now based on inclusion of needless APOLLO-only changes in the patch.
Alp Toker
Comment 6 2007-12-23 01:15:05 PST
Created attachment 18069 [details] Cairo graphics fixes In this patch I've extracted all useful modifications to shared code, modified it to follow coding style, studied and documented the effects in the ChangeLog entry. We only cover GraphicsContextCairo.cpp and ImageSourceCairo.cpp here. There are several other good fixes that still need to be merged in other files from the Apollo port.
Holger Freyther
Comment 7 2007-12-23 16:21:02 PST
Comment on attachment 18069 [details] Cairo graphics fixes Looks sane.
Alp Toker
Comment 8 2007-12-23 17:12:15 PST
Landed in r28969.
Note You need to log in before you can comment on or make changes to this bug.