Bug 16511 - Speed up ClassNodeList and NamedNodeList by using the caching mechanism employed by ChildNodeLists
Summary: Speed up ClassNodeList and NamedNodeList by using the caching mechanism emplo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-18 20:10 PST by Sam Weinig
Modified: 2007-12-19 12:11 PST (History)
0 users

See Also:


Attachments
patch (13.23 KB, patch)
2007-12-18 20:12 PST, Sam Weinig
sam: review-
Details | Formatted Diff | Diff
second try (14.11 KB, patch)
2007-12-18 23:06 PST, Sam Weinig
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-12-18 20:10:37 PST
This turned out to be quite easy and a big win.
Comment 1 Sam Weinig 2007-12-18 20:12:41 PST
Created attachment 17979 [details]
patch
Comment 2 Sam Weinig 2007-12-18 20:21:14 PST
Ignore the stuff in DRT, that was not intended to be there.
Comment 3 Sam Weinig 2007-12-18 20:29:16 PST
Comment on attachment 17979 [details]
patch

Scratch that, there seems to be an invalidation error I missed.  Will return shortly.
Comment 4 Sam Weinig 2007-12-18 23:06:49 PST
Created attachment 17982 [details]
second try

This time with less test failures!
Comment 5 Maciej Stachowiak 2007-12-19 01:06:25 PST
Comment on attachment 17982 [details]
second try

r=me
Comment 6 Sam Weinig 2007-12-19 12:11:39 PST
Landed in r28868.