Bug 16438 - another round of PCRE clean-up
Summary: another round of PCRE clean-up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P3 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-14 10:45 PST by Darin Adler
Modified: 2007-12-16 20:20 PST (History)
0 users

See Also:

Attachments
patch (all regression tests pass) (168.46 KB, patch)
2007-12-14 11:08 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (all regression tests pass) (168.20 KB, patch)
2007-12-15 20:01 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
patch with "ignore whitespace differences" on -- may be easier to review (158.42 KB, patch)
2007-12-15 20:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
patch rebased to r28788 (168.27 KB, patch)
2007-12-16 17:36 PST, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-12-14 10:45:59 PST 
While looking into a regression, which I'll fix soon, I did another round of PCRE code tweaks.
Comment 1 Darin Adler 2007-12-14 11:08:11 PST 
Created attachment 17896 [details]
patch (all regression tests pass)
Comment 2 Darin Adler 2007-12-15 20:01:45 PST 
Created attachment 17921 [details]
patch (all regression tests pass)

Earlier patch had an extra ChangeLog entry.
Comment 3 Darin Adler 2007-12-15 20:02:11 PST 
Created attachment 17922 [details]
patch with "ignore whitespace differences" on -- may be easier to review
Comment 4 Darin Adler 2007-12-16 17:36:06 PST 
Created attachment 17947 [details]
patch rebased to r28788
Comment 5 Maciej Stachowiak 2007-12-16 18:04:38 PST 
Comment on attachment 17947 [details]
patch rebased to r28788

r=me
Comment 6 Darin Adler 2007-12-16 20:20:38 PST 
Committed revision 28793.