Bug 16420 – change regression tests to use document.execCommand instead of textInputController.doCommand

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Darin Adler]

document.execCommand is cross-platform, and textInputController.doCommand is Mac OS X only.

So we should change cross-platform tests to use execCommand.

[Darin Adler]

Created attachment 17874 [details]
work in progress (includes some unrelated changes)

[Darin Adler]

Created attachment 17892 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 17892 [details]
patch

r=me

+        (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for
+        NSTextView. This was left over from when we used NSTextField and NSTextView for form
+        elements and is no longer used at all.

I think I heard about some plug-ins creating Cocoa views - can this break them?

+static bool verticalScrollDistance(Frame* frame)

This sounds like it should be int.

-if (window.layoutTestController)
-    textInputController.doCommand("selectLine:");
+document.execCommand("SelectLine");

Some of these tests have comments saying that they cannot be run outside DRT - perhaps these comments should be removed.

[Darin Adler]

(In reply to comment #3)
> (From update of attachment 17892 [details] [edit])
> r=me
> 
> +        (WebCore::EventHandler::passMouseDownEventToWidget): Removed the
> special case code for
> +        NSTextView. This was left over from when we used NSTextField and
> NSTextView for form
> +        elements and is no longer used at all.
> 
> I think I heard about some plug-ins creating Cocoa views - can this break them?

These changes might have some small effect on such plug-ins, but I'm pretty sure that the old behavior wasn't even particularly helpful for them. It was specifically aimed at our form elements; for example it only worked if the top level NSView in a plug-in was an NSTextField or NSTextView, which is highly unlikely.

> +static bool verticalScrollDistance(Frame* frame)
> 
> This sounds like it should be int.

Uh oh! Good catch!

> -if (window.layoutTestController)
> -    textInputController.doCommand("selectLine:");
> +document.execCommand("SelectLine");
> 
> Some of these tests have comments saying that they cannot be run outside DRT -
> perhaps these comments should be removed.

Yes, I mentioned those in my ChangeLog.

+        To avoid changing results at this time, I didn't correct the many tests that now have
+        misleading "this test cannot be run manually" text or references to "NSResponder" or
+        uneeded instructions for running the test manually. We can do that on a later pass.

[Darin Adler]

Committed revision 28717.