Bug 16389 – Common Implementation of NetscapePlugInStreamLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Rodney Dawes]

The code in NetscapePlugInStreamLoaderWin.cpp is not specific to win32, and is usable on other platforms as well. We should use this code as the default implementation, rather than having no implementation for the default. This patch adds this code to the common loader/NetscapePlugInStreamLoader.cpp as the common default implementation.

[Rodney Dawes]

Created attachment 17829 [details]
Common impl of NetscapePlugInStreamLoader

[Mark Rowe (bdash)]

Comment on attachment 17829 [details]
Common impl of NetscapePlugInStreamLoader

My reading of this suggests that we'd now have two identical implementations of NetscapePlugInStreamLoader in the tree.  This code should be shared rather than duplicated.

[Rodney Dawes]

(In reply to comment #2)
> (From update of attachment 17829 [details] [edit])
> My reading of this suggests that we'd now have two identical implementations of
> NetscapePlugInStreamLoader in the tree.  This code should be shared rather than
> duplicated.
> 

This would be that shared code. I don't know how to remove the file from the win32 builds, as a different build system is used there. I could remove the win32 port file from svn with this patch, but then it would just break the build. The appropriate build files need to be updated as well. Should I just resubmit with the file removal in the patch also?

[Rodney Dawes]

Created attachment 17868 [details]
Updated patch to remove win32 specific portions

This updated patch also removes the NetscapePlugInLoaderWin.cpp file and it's reference in the WebCore.vcproj.

[Maciej Stachowiak]

Comment on attachment 17868 [details]
Updated patch to remove win32 specific portions

r=me

[Mark Rowe (bdash)]

Landed in r28790.