Bug 16353 – [GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alp Toker]

We should have a special build target (perhaps in addition to Debug and Release) that can be used to check for deprecated API use in WebKit/GTK+.

These are the relevant flags GIMP enables:

-DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE

We would also add (for the GStreamer code):

-DGST_DISABLE_DEPRECATED

There may be others I've missed, but these seem the most important.

These flags probably shouldn't be used in standard build profiles since they may cause the build to break needlessly in the long term. They should be used only to assist developers in tracking down bad API use, similarly to -Werror.

[Jan Alonzo]

Hi! I don't see why we need another target for this. Normally, _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are usually the place for fixing this sort of things. 

> These flags probably shouldn't be used in standard build profiles since they
> may cause the build to break needlessly in the long term

Just wondering what sort of build breakages are you expecting to come if we enable these flags in the 'debug' build?

[Alp Toker]

(In reply to comment #1)
> Hi! I don't see why we need another target for this. Normally,
> _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are
> usually the place for fixing this sort of things.

Adding these flags only for debug builds sounds fine to me. We don't want to use them in release builds since a release build needs to be forward-compatible.

[Jan Alonzo]

Created attachment 18130 [details]
patch to define the flags mentioned during debug builds

This patch defines the flags only when doing debug builds.

cheers

[Alp Toker]

Comment on attachment 18130 [details]
patch to define the flags mentioned during debug builds

r=me

There's some bad whitespace changes in WebCore.pro and you missed wrapping GST_DISABLE_DEPRECATED withCONFIG(debug) though. Will fix up before landing.

[Alp Toker]

Landed in r29006.