Bug 16348 – @font-face does not affect the default style

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

"Unstyled" text is unaffected by @font-face rules. See the attached test case.

Created attachment 17784 [details]
Test case

Created attachment 17786 [details]
Use the current font selector for the document style

Fixed in <http://trac.webkit.org/projects/webkit/changeset/28555>.

[Dean McNamee]

I just tried Windows Safari with WebKit r39939, and it looks to me the font is displayed in Times.

I am trying to figure out if there is a regression in Chromium (specifically Linux), but I'm not sure what behavior to expect or if there are other factors.  The mac expected pixel image is clearly in Arial.  I know we don't really support font-face on Chromium Linux right now, but I'm just trying to figure out what behavior we should be matching.

Additionally, in Chromium Windows, where we do support font-face and dynamic fonts, it is also still rendered as Times.

Thanks

[Dean McNamee]

On further inspection, it seems the difference is font-family: Times; vs font-family; times new roman;  If I change the CSS to use a font-family: times new roman;, then both Windows Safari nightly webkit, Chromium Windows, and Chromium Linux render the text in Arial.

Should I update the test?

[Dean McNamee]

Created attachment 26788 [details]
Times -> times new roman

I'm not sure if this is right on the Mac, and I don't have one to test.  If there really is the difference between 'Times' and 'times new roman' being the default fonts between Mac and Windows, then I guess the best solution would be to have two @font-face in the CSS, for both 'Times' and 'times new roman'.

Sorry if I should have created a new bug for this, just seemed like a bunch of overhead.

[Dean McNamee]

Created attachment 26789 [details]
Times and times new roman

Just for convenience, I've uploaded the patched for the second approach of having font-face for both possibilities.  If one of the two approaches sounds alright, feel free to commit it for me.  Thanks.

(In reply to comment #5)
> On further inspection, it seems the difference is font-family: Times; vs
> font-family; times new roman;  If I change the CSS to use a font-family: times
> new roman;, then both Windows Safari nightly webkit, Chromium Windows, and
> Chromium Linux render the text in Arial.
> 
> Should I update the test?

The tests run in an environment where the standard font is Times both on Mac and on Windows.

[Dean McNamee]

(In reply to comment #8)
> (In reply to comment #5)
> > On further inspection, it seems the difference is font-family: Times; vs
> > font-family; times new roman;  If I change the CSS to use a font-family: times
> > new roman;, then both Windows Safari nightly webkit, Chromium Windows, and
> > Chromium Linux render the text in Arial.
> > 
> > Should I update the test?
> 
> The tests run in an environment where the standard font is Times both on Mac
> and on Windows.
> 

But they don't pass when you run them standalone in the browser.  Is there any disadvantage to changing that?  In our test environment, our default font is 'times new roman', which matches our final product.  I don't see any harm in making the patch work in both cases.

[Darin Adler]

Comment on attachment 26788 [details]
Times -> times new roman

Why all lowercase like this? Why no quote marks around the multi-word family name?

[Aaron Boodman]

Created attachment 28455 [details]
Capitalize and quote "Times New Roman"

[Dave Hyatt]

Comment on attachment 28455 [details]
Capitalize and quote "Times New Roman"

r=me

[David Levin]

Assigned to levin for landing.

[David Levin]

Committed r41653.