RESOLVED WONTFIX 16344
Unnecessarily calling $QMAKE_MOC 
https://bugs.webkit.org/show_bug.cgi?id=16344
Summary Unnecessarily calling $QMAKE_MOC
Rodney Dawes
Reported 2007-12-07 12:29:08 PST
We are calling $QMAKE_MOC unnecessarily when generating various files. The attached patch removes these unneeded arguments.
Attachments
Remove unnecessary $QMAKE_MOC usage (5.28 KB, patch)
2007-12-07 12:33 PST, Rodney Dawes 		mrowe: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2007-12-07 12:33:29 PST
Created attachment 17779 [details] Remove unnecessary $QMAKE_MOC usage
Alp Toker
Comment 2 2007-12-08 01:52:09 PST
Does this affect the Qt build? If Qt needs this, I don't think there's any harm in calling it for GTK+ too. If Qt doesn't need it, let's remove it.
Simon Hausmann
Comment 3 2007-12-10 04:07:50 PST
I don't see why the use of $QMAKE_MOC is unnecessary. The perl scripts in question call gcc -E, which is not available for example when compiling in a Windows environment without cygwin. For the Qt build that is a supported build combination, and that is why we use moc's builtin primitive preprocessor for those build scripts.
Note You need to log in before you can comment on or make changes to this bug.