There are multiple errors of the following type in platform/gtk: ../../../WebCore/platform/gtk/PlatformScrollBarGtk.cpp:76: error: ISO C++ forbids casting between pointer-to-function and pointer-to-object ../../../WebCore/platform/gtk/PlatformScrollBarGtk.cpp:77: error: ISO C++ forbids casting between pointer-to-function and pointer-to-object There are also a couple of warnings about other casts as well. The attached patch fixes these problems.
Did you mean to attach a patch?
Created attachment 17775 [details] Patch to fix warnings and errors Here's the patch. Had to update, get lunch, and tweak a few things. :)
Is there a compiler flag that we can use to disable the warning about casting a function-pointer to an object-pointer? That would be much cleaner than introducing C-style casts. What does moving the initialization of m_adjustment out of the initialization list fix?
Created attachment 17822 [details] Updated patch Here's an updated patch without the m_adjustment change. I just tried to get the warning again, and it's not appearing. I have no idea why. I also don't know what the warning flag would be for the ISO C++ warnings.
Comment on attachment 17822 [details] Updated patch r=me The C-style casts are probably not that big a deal for extreme casting like this.
Landed in r28654 with minor style fixes (remove excess parentheses).