RESOLVED FIXED 16336
Fix wx port page leaks
https://bugs.webkit.org/show_bug.cgi?id=16336
Summary Fix wx port page leaks
Kevin Ollivier
Reported 2007-12-06 22:11:17 PST
In tests, we've found m_impl->frame->page() to be NULL after detachFromParent() is called, which makes our delete m_impl->frame->page() code to be a no-op and causes the page to leak on shutdown. To fix this, we retain a pointer to the page so that we can delete it on shutdown.
Attachments
Fix for page leaks in wxWebKit (4.51 KB, patch)
2007-12-06 22:12 PST, Kevin Ollivier
darin: review+
Kevin Ollivier
Comment 1 2007-12-06 22:12:07 PST
Created attachment 17764 [details] Fix for page leaks in wxWebKit
Darin Adler
Comment 2 2007-12-07 01:14:34 PST
Comment on attachment 17764 [details] Fix for page leaks in wxWebKit Looks fine. The delete call doesn't need the check for 0, because delete already does that. r=me
Kevin Ollivier
Comment 3 2007-12-07 09:25:53 PST
landed in r25818
Note You need to log in before you can comment on or make changes to this bug.