Bug 16306 – Assertion failed in WebCore/loader/FrameLoader.cpp:4642

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Michael Graham]

I have just build webkit with gtk and debug and an assertion fails on startup

ASSERT(!m_didDispatchDidCommitLoad);

I attached to the process and I can see what is going on (fixing is a whole other ball game!)

* dispatchDidCommitLoad is called and m_didDispatchDidCommitLoad is set true
* checkLoadCompleteForThisFrame is called and we return early because m_creatingInitialEmptyDocument==true
* dispatchDidCommitLoad is called and the assertion fails

[Alp Toker]

The assertion added in r28399 is causing this issue.

[David Kilzer (:ddkilzer)]

I'm not seeing this with a local debug build of WebKit r28434 on Mac OS X 10.4.11 (8S165).

[Alp Toker]

(In reply to comment #2)
> I'm not seeing this with a local debug build of WebKit r28434 on Mac OS X
> 10.4.11 (8S165).
> 

The reports of this issue I've seen have been in the GTK+, suggesting that either the assertion is identifying something we're doing wrong in the port, or the assertion is too strict and needs to be removed.

 	5	        - added an assertion for a situation that leads to a Safari assertion: 
 	6	          a commit that is not followed by a load completion 

http://trac.webkit.org/projects/webkit/changeset/28399

Sounds like this may be a bug we need to fix in the GTK+ port rather than just removing the assertion and moving on.

Darin, Kevin, any thoughts?

[Darin Adler]

Created attachment 17720 [details]
patch

[Adam Roben (:aroben)]

Comment on attachment 17720 [details]
patch

r=me