Bug 16290 – [GTK] Pasting clipboard in rich text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Luca Bruno]

Hello,
i created a patch which implements documentFragment but doesn't work pretty well.
The problem is that the fragment is not pasted everywhere (in blogger for example).

I don't think at all it's a problem if how documentFragment has been implemented.
Any hint?

[Luca Bruno]

Created attachment 17702 [details]
documentFragment implementation

[Luca Bruno]

Created attachment 17712 [details]
complete patch

I written this code according to the Qt implementation, and i think for now it's both complete and enough.

[Alp Toker]

This works well.

Can you fix up the patch so:

 There are no spaces before parentheses:
  gdk_atom_intern_static_string ("text/html")

ChangeLog should use spaces not tabs. Reviewer field should be left empty.

+                if (fragment)
+                    return fragment.release();
+            }
+            gtk_selection_data_free (data);

This looks like a leak. data isn't freed when returning early.


Thanks!

[Alp Toker]

        String text = String::fromUTF8(gtk_clipboard_wait_for_text(clipboard));

This is also a leak. The return value must be freed -- see the code a few lines below for an example.

[Luca Bruno]

Created attachment 17723 [details]
corrected patch

Thanks for all these hints. Hope this is good this time.

[Alp Toker]

Comment on attachment 17723 [details]
corrected patch

r=me with the changes we discussed.

[Alp Toker]

Landed in r28448. Thanks, looking forward to copying support!