Bug 16218 - [GTK] API: Should this entry point be called go_back rather than go_backward?
Summary: [GTK] API: Should this entry point be called go_back rather than go_backward?
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-11-30 20:33 PST by Alp Toker
Modified: 2008-01-16 18:28 PST (History)
1 user (show)

See Also:

Attachments
go_back patch (1.87 KB, patch)
2007-12-02 03:10 PST, Jan Alonzo 		no flags Details | Formatted Diff | Diff
API fix and documentation (7.51 KB, patch)
2008-01-16 05:47 PST, Alp Toker 		no flags Details | Formatted Diff | Diff
Fixed comments; better obsolete messages (7.49 KB, patch)
2008-01-16 18:18 PST, Alp Toker 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-11-30 20:33:33 PST 
go_back() is the de-facto standard in the browser world.

The GTK+ port instead provides go_backward(), presumably to remain consistent with the corresponding de-facto go_forward()

Browsers usually have "Back" and "Forward" buttons.

However GTK+ developers have a history of breaking popular conventions in favour of grammatical consistency or a strong conviction of "correctness" (eg. URI vs URL).

Do we want to stick with what we have or follow the crowd?

This is relevant to WebKitWebView and possibly WebKitWebFrame and other classes.

Christian originally raised this question but hasn't yet written up the bug so I went ahead and did so.
Comment 1 Jan Alonzo 2007-12-02 03:10:45 PST 
Created attachment 17640 [details]
go_back patch

I prefer "go back" because I want to be part of the crowd :) and also because WebView of the Mac and Win ports also use "go back" in their API.

I've attached a patch to use go_back instead of go_backward. It's not for review until there's a decision about the API.
Comment 2 Alp Toker 2008-01-16 05:47:17 PST 
Created attachment 18471 [details]
API fix and documentation

New symbols added, old symbols deprecated.
Comment 3 Alp Toker 2008-01-16 18:18:04 PST 
Created attachment 18486 [details]
Fixed comments; better obsolete messages
Comment 4 Alp Toker 2008-01-16 18:28:14 PST 
Landed in r29550.