Bug 16181 – REGRESSION: Crash hitting enter/backspace/enter rapidly with the caret after a form control

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: HTML Editing

[J Boss]

If an iframe is in designMode and there is an <input type="submit"> or <input type="reset">, if the cursor is immediately after that element and the user presses enter:

If the <input> element is the first <input type="submit"> or <input type="reset"> element on the line, the browser will crash.

If there are multiple <input type="submit"> or <input type="reset"> elements in succession and the cursor is not on the first one, an additional copy of that element will be created immediately after the original one.

[Mark Rowe (bdash)]

Can you please attach a test case demonstrating the bug?  It will make it much easier to confirm and test.

[Mark Rowe (bdash)]

<rdar://problem/5619285>

[J Boss]

Created attachment 17636 [details]
testcase

[Alexey Proskuryakov]

ASSERTION FAILED: canHaveChildrenForEditing(parent)
(/Users/ap/WebKit/WebCore/editing/CompositeEditCommand.cpp:177 void WebCore::CompositeEditCommand::appendNode(WebCore::Node*, WebCore::Node*))

[Alexey Proskuryakov]

I cannot reproduce this anymore, but I'm getting a different crash when quickly pressing Enter/Backspace/Enter/...

#0	0x01b0eb89 in WebCore::Node::renderer at Node.h:334
#1	0x01d3c303 in WebCore::InsertLineBreakCommand::shouldUseBreakElement at InsertLineBreakCommand.cpp:87
#2	0x01d3c5d5 in WebCore::InsertLineBreakCommand::doApply at InsertLineBreakCommand.cpp:105
#3	0x01c2f411 in WebCore::EditCommand::apply at EditCommand.cpp:87
#4	0x01b81be5 in WebCore::CompositeEditCommand::applyCommandToComposite at CompositeEditCommand.cpp:97
#5	0x01d3f96c in WebCore::InsertParagraphSeparatorCommand::doApply at InsertParagraphSeparatorCommand.cpp:107
#6	0x01c2f411 in WebCore::EditCommand::apply at EditCommand.cpp:87
#7	0x01b81be5 in WebCore::CompositeEditCommand::applyCommandToComposite at CompositeEditCommand.cpp:97
#8	0x020876aa in WebCore::TypingCommand::insertParagraphSeparator at TypingCommand.cpp:358
#9	0x02087b19 in WebCore::TypingCommand::insertParagraphSeparator at TypingCommand.cpp:222
#10	0x01c33a34 in WebCore::Editor::insertParagraphSeparator at Editor.cpp:906
#11	0x01c4132c in WebCore::EventHandler::defaultTextInputEventHandler at EventHandler.cpp:1832
#12	0x01c4f71e in WebCore::EventTargetNode::defaultEventHandler at EventTargetNode.cpp:417
#13	0x01c4dd97 in WebCore::EventTarget::dispatchGenericEvent at EventTarget.cpp:255
#14	0x01c4ee1e in WebCore::EventTargetNode::dispatchEvent at EventTargetNode.cpp:114
#15	0x01c43bf6 in WebCore::EventHandler::handleTextInputEvent at EventHandler.cpp:1801
#16	0x02104721 in executeInsertNewline at EditorCommand.cpp:468
#17	0x021042c1 in WebCore::Editor::Command::execute at EditorCommand.cpp:1345
#18	0x02104533 in WebCore::Editor::Command::execute at EditorCommand.cpp:1350
#19	0x001d8d10 in -[WebHTMLView(WebNSTextInputSupport) doCommandBySelector:] at WebHTMLView.mm:5065
#20	0x001d20a6 in -[WebHTMLView(WebInternal) _interceptEditingKeyEvent:shouldSaveCommand:] at WebHTMLView.mm:4727
#21	0x001a5d78 in WebEditorClient::handleKeyboardEvent at WebEditorClient.mm:437

[Justin Garcia]

(In reply to comment #5)
> I cannot reproduce this anymore, but I'm getting a different crash when quickly
> pressing Enter/Backspace/Enter/...

Right, I fixed the original crash last week in r28710.  Changing this bug to cover the new crash that Alexey discovered.

[jay]

os x 10.6.7
Version 5.0.5 (6533.21.1, r88132)

wfm

ap mrowe please check testcase, not clear this bug should be open

[Alexey Proskuryakov]

Yeah, seems fixed.