RESOLVED FIXED 16138
Reduce code duplication in WebView.cpp 
https://bugs.webkit.org/show_bug.cgi?id=16138
Summary Reduce code duplication in WebView.cpp
Adam Roben (:aroben)
Reported 2007-11-25 22:49:26 PST
WebView.cpp contains some duplicated code for figuring out repaint rects. We should fix that.
Attachments
Refactor WebView's repaint rect code (10.17 KB, patch)
2007-11-25 22:50 PST, Adam Roben (:aroben) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2007-11-25 22:50:45 PST
Created attachment 17525 [details] Refactor WebView's repaint rect code Reviewed by NOBODY (OOPS!). * WebView.cpp: (getUpdateRects): Factored code out of updateBackingStore and paint into this new helper function. (WebView::updateBackingStore): Use getUpdateRects. (WebView::paint): Ditto. (WebView::paintIntoBackingStore): Changed to take a const IntRect&. (WebView::paintIntoWindow): Ditto. * WebView.h: --- WebKit/win/ChangeLog | 15 +++++ WebKit/win/WebView.cpp | 143 ++++++++++++++++++++++++------------------------ WebKit/win/WebView.h | 4 +- 3 files changed, 88 insertions(+), 74 deletions(-)
Sam Weinig
Comment 2 2007-11-25 22:59:00 PST
Comment on attachment 17525 [details] Refactor WebView's repaint rect code r=me
Adam Roben (:aroben)
Comment 3 2007-11-25 23:03:22 PST
Landed as r28036
Note You need to log in before you can comment on or make changes to this bug.