Bug 16136 - Use shared PixelDumpSupport for Mac DRT
Summary: Use shared PixelDumpSupport for Mac DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-25 18:25 PST by Sam Weinig
Modified: 2007-11-26 13:17 PST (History)
0 users

See Also:


Attachments
patch (70.54 KB, patch)
2007-11-26 10:47 PST, Sam Weinig
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-11-25 18:25:56 PST
Now that the windows pixel dump code has landed, we should use the same code for both platform where possible.
Comment 1 Sam Weinig 2007-11-26 10:47:55 PST
Created attachment 17532 [details]
patch
Comment 2 Adam Roben (:aroben) 2007-11-26 10:54:28 PST
Comment on attachment 17532 [details]
patch

You might mention in the ChangeLog that you're now using ImageDiffCG as well.

+void drawWebViewIntoContext(CGContextRef);
+void repaintWithVerticalSweep(CGContextRef);
+void repaintWithHorizontalSweep(CGContextRef);
+void drawSelectionRectIntoContext(CGContextRef, CGRect);

How about:

void paintWebView(CGContextRef);
void repaintWebView(CGContextRef, bool horizontal);
void drawSelectionRect(CGContextRef, const CGRect&);

r=me
Comment 3 Sam Weinig 2007-11-26 13:17:06 PST
Fixes landed in r28042 and r28047.