RESOLVED FIXED 16105
NetscapePlugInStreamLoader has unnecessary #ifs for CFNETWORK 
https://bugs.webkit.org/show_bug.cgi?id=16105
Summary NetscapePlugInStreamLoader has unnecessary #ifs for CFNETWORK
Rodney Dawes
Reported 2007-11-23 14:21:00 PST
Portions of the API in NetscapePlugInStreamLoader.h are #ifed out with checks for CFNETWORK, while CFNETWORK is not required to implement the API in a platform class. The attached patch fixes this.
Attachments
Patch to not disable portions of the API without CFNETWORK (1.92 KB, patch)
2007-11-23 14:21 PST, Rodney Dawes 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2007-11-23 14:21:35 PST
Created attachment 17472 [details] Patch to not disable portions of the API without CFNETWORK
Alp Toker
Comment 2 2007-11-23 15:50:01 PST
I think the ChangeLog needs to be updated with an explanation of why the conditional checks are no longer needed. Can you check SVN history to find out why they were put there to begin with, and if any build configuration still needs them?
Maciej Stachowiak
Comment 3 2007-11-24 19:09:15 PST
Comment on attachment 17472 [details] Patch to not disable portions of the API without CFNETWORK If this doesn't break any builds, r=me.
Mark Rowe (bdash)
Comment 4 2007-11-25 18:38:35 PST
Landed in r28029 after tweaking it to not break the build. Rodney, can you please leave the "Reviewed by NOBODY (OOPS!)" line in your changelog entries in the future? It helps ensure that the committer adds the reviewer's name as our pre-commit hooks will catch the "NOBDOY (OOPS!)".
Note You need to log in before you can comment on or make changes to this bug.