Bug 16102 – Safari crashes at IMDb when going back in history

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Espen B. Andersson]

1. Go to URL.
2. Click the "The Shining (1980)" link below "Popular Titles".

Safari crashes at almost every attempt.

[David Kilzer (:ddkilzer)]

Thanks for the bug report, Espen.  Could you post or attach a crash log?  Thanks!

http://webkit.org/quality/crashlogs.html#win

[David Kilzer (:ddkilzer)]

Can't reproduce with a local debug build of WebKit r27971 with Safari 3.0.4 (523.12) on Mac OS X 10.4.11 (8S165).

[Espen B. Andersson]

David, it seems Vista doesn't come with Dr. Watson. Is there any other tool I can use to generate a crashlog?

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> David, it seems Vista doesn't come with Dr. Watson. Is there any other tool I
> can use to generate a crashlog?

I think there is a work-around for Vista, but I don't know what it is.  (It needs to be documented on the webkit.org site, though.)

[David Kilzer (:ddkilzer)]

Matt may know/remember the work-around for Vista as well.

[Matt Lilek]

There is no easy way that I know off to get a backtrace or reasonably-sized memory dump on Vista short of installing Visual Studio/Visual C++ Express and using that to get a backtrace or grabbing Dr Watson off an XP box.  (There are some downloadable tools you can use to get memory dumps, but even when compressed, they are far too large to upload to bugzilla.)

That said, I can't reproduce a crash on IMDB on XP with Safari 3.0.4 or ~ToT.

[Espen B. Andersson]

Well, it could be Vista specific for all I know. I just did some more testing, and Safari seems to almost always crash when I follow a link from a search on that page. If I go directly to the target using the address field, it works just fine.

[Espen B. Andersson]

Safari keeps crashing. Anything I can do to help?

[Alexey Proskuryakov]

Have you tested with nightly builds (http://nightly.webkit.org)? It's possible that the problem was fixed already (I wouldn't count on it, but it's easier to check!).

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> Safari keeps crashing. Anything I can do to help?

Can you get access to a Windows XP system to test?  (If it crashes, use the instructions on the web page in Comment #1 to get a dump file.)

[Espen B. Andersson]

Crashes on WinXP as well.

[Espen B. Andersson]

Created attachment 17938 [details]
Crashlog.

[David Kilzer (:ddkilzer)]

<rdar://problem/5650446>

[Espen B. Andersson]

David: What does <rdar://problem/5650446> mean?

Oh, and by the way (if it's of any use): I've received several confirmation that Safari often crashes on IMDb when browsing picture galleries on OS X. Would a crashlog be of any help?

[Espen B. Andersson]

Created attachment 18225 [details]
Crashlog from Safari on OS X while browsing IMDb.com

[Espen B. Andersson]

Created attachment 18226 [details]
Crashlog from Safari on OS X while browsing IMDb.com [NEW]

[Espen B. Andersson]

A third crashlog from another computer is also available at http://pastebin.no/2981

[David Kilzer (:ddkilzer)]

(In reply to comment #14)
> David: What does <rdar://problem/5650446> mean?

This is an identifier for Apple's internal bug tracking system, Radar.

> Oh, and by the way (if it's of any use): I've received several confirmation
> that Safari often crashes on IMDb when browsing picture galleries on OS X.
> Would a crashlog be of any help?

This seems like a different bug, so a different bug should be created for it.  However, did you start seeing this after Security Update 2007-009?  Have you installed Seucrity Update 2007-009 v1.1?

http://docs.info.apple.com/article.html?artnum=61798

[Espen B. Andersson]

I haven't installed Security Update 2007-009 yet.

[David Kilzer (:ddkilzer)]

(In reply to comment #14)
> Oh, and by the way (if it's of any use): I've received several confirmation
> that Safari often crashes on IMDb when browsing picture galleries on OS X.
> Would a crashlog be of any help?

It appears you have some Safari extensions installed:

0x31b000 -   0x31cfff com.Logitech.Control Center.Scroll Enhancer 2.1.1	/Library/Application Enhancers/LCC Scroll Enhancer.ape/Contents/MacOS/LCC Scroll Enhancer
0xc0000000 - 0xc000efff com.unsanity.ape 2.0.1	/Library/Frameworks/ApplicationEnhancer.framework/Versions/A/ApplicationEnhancer

Please try disabling these items to see if that fixes the crashes on Mac OS X.

[Espen B. Andersson]

With the Logitech stuff disabled, I get this crashlog:

http://pastebin.no/2986

[David Kilzer (:ddkilzer)]

(In reply to comment #21)
> With the Logitech stuff disabled, I get this crashlog:
> 
> http://pastebin.no/2986

You still have Saft installed:

0x33b000 -   0x33cfff com.li.hao.saftloader 1.3.1 (458)    /Library/InputManagers/Saft/SaftLoader.bundle/Contents/MacOS/SaftLoader

Please disable/remove Saft and try testing again.

Also, PLEASE open a new bug for the OS X issues if removing Saft doesn't fix the issue.  We are polluting the original bug (which is a Windows XP crasher on IMDB).

[Anders Carlsson]

Espen, are you logged into imdb while doing this? How easy is it to reproduce?

[Espen B. Andersson]

Anders: Sorry for the lack of response. I'm not on OS X myself, so it's kind of hard to test with plugins disabled. I just did a quick test again, and it seems to crash just about every time I do a search and follow one of the results. This time I wasn't logged in, using WinXP and Safari 3.0.4 (523.15).

[Anders Carlsson]

Thank you for your response Espen! 

Do you see any special ads on any of the pages? What type of internet connection are you on?

(I suspect that this is a timing related bug which is why I'm having trouble reproducing it)

[Espen B. Andersson]

Disabling Javascript makes the crash go away, so it's either a Javascript crash (doubt it) or related to one of the ads that's included using JS (assume this one's to blame).

An easy way for me to reproduce is to have JS activated, then searching for "departed", following "The Departed (2006)" and then going back to the search results.

I'm on a pretty good connection (2 830 kbit/s).

[Anders Carlsson]

What types of ads do you see? If you could make a screenshot of both pages and attach it would be great!

[Espen B. Andersson]

Created attachment 18519 [details]
Screenshot of website

[Espen B. Andersson]

Anders: Please see the latest attachment. That's a screenshot of the search result page Safari just crashed at when going back in history from the "The Departed" page. It's seems to be the ad to the right that's the culprit.

[David Kilzer (:ddkilzer)]

Espen, can you capture an IMDB page with the problematic ad in Firefox, then use the "Save as..." feature to save a "web page, complete" formatted page?  (You might also try saving the source of the original page.)  Once this is done, please zip up the "web page, complete" files and attach to this bug.  (Attach the web page source if you save it as well.)

[Espen B. Andersson]

Created attachment 18983 [details]
Package to reproduce the crash

[Espen B. Andersson]

David, please see the new attachment. By loading find.htm in Safari, then following the first link to The Departed (2006) (which points to imdb.com) and then going back, Safari always crashes.

[Anders Carlsson]

Espen, thank you so much! I was finally able to reproduce this reliably! I am trying to figure out what's going on now. Once again, thanks!

[Espen B. Andersson]

(In reply to comment #33)
> Espen, thank you so much! I was finally able to reproduce this reliably! I am
> trying to figure out what's going on now. Once again, thanks!

Great! Feel free to keep me posted :-)

[Anders Carlsson]

Committed revision 30101.

[Espen B. Andersson]

(In reply to comment #35)
> Committed revision 30101.

Great, that was fast :-) Two questions:

- May I ask what triggered the crash?
- When will the fix be in a public release?

[Anders Carlsson]

* What triggered the crash was that an onload handler was moving around frames, changing the frame hierarchy while we were traversing the same hierarchy stopping loads.

* We can't comment on future products, but you should be able to verify that the bug has been fixed using a nightly build - see http://nightly.webkit.org/