RESOLVED FIXED 16080
Clean up DRT code 
https://bugs.webkit.org/show_bug.cgi?id=16080
Summary Clean up DRT code
Eric Seidel (no email)
Reported 2007-11-21 01:11:37 PST
I went to hack on DRT tonight, to finally fix bug 15565, but was annoyed at bad code abstraction in DRT. So I fixed a little of it. I'll upload my git commits in a sec.
Attachments
[PATCH] Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files (29.41 KB, patch)
2007-11-21 01:12 PST, Eric Seidel (no email) 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] Abstract more of DRT into static methods (9.87 KB, patch)
2007-11-21 01:12 PST, Eric Seidel (no email) 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-11-21 01:12:37 PST
Created attachment 17426 [details] [PATCH] Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files WebKitTools/DumpRenderTree/DumpRenderTree.h | 2 + .../DumpRenderTree.xcodeproj/project.pbxproj | 40 +++- WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm | 227 +------------------- .../DumpRenderTree/mac/DumpRenderTreePasteboard.h | 35 +++ .../DumpRenderTree/mac/DumpRenderTreePasteboard.m | 201 +++++++++++++++++ .../DumpRenderTree/mac/DumpRenderTreeWindow.h | 35 +++ .../DumpRenderTree/mac/DumpRenderTreeWindow.mm | 85 ++++++++ 7 files changed, 401 insertions(+), 224 deletions(-)
Eric Seidel (no email)
Comment 2 2007-11-21 01:12:38 PST
Created attachment 17427 [details] [PATCH] Abstract more of DRT into static methods WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm | 168 +++++++++++++--------- 1 files changed, 102 insertions(+), 66 deletions(-)
Timothy Hatcher
Comment 3 2007-11-21 08:25:55 PST
Comment on attachment 17426 [details] [PATCH] Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files +++ b/WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h \ No newline at end of file Add a new line. r=me
Timothy Hatcher
Comment 4 2007-11-21 08:30:34 PST
Comment on attachment 17427 [details] [PATCH] Abstract more of DRT into static methods You should make createCFURLFromPathOrURL static too. r=me
Eric Seidel (no email)
Comment 5 2007-11-21 11:29:45 PST
Landed (with your suggested changes) as r27941 and r27942
Note You need to log in before you can comment on or make changes to this bug.