I went to hack on DRT tonight, to finally fix bug 15565, but was annoyed at bad code abstraction in DRT. So I fixed a little of it. I'll upload my git commits in a sec.
Created attachment 17426 [details] [PATCH] Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files WebKitTools/DumpRenderTree/DumpRenderTree.h | 2 + .../DumpRenderTree.xcodeproj/project.pbxproj | 40 +++- WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm | 227 +------------------- .../DumpRenderTree/mac/DumpRenderTreePasteboard.h | 35 +++ .../DumpRenderTree/mac/DumpRenderTreePasteboard.m | 201 +++++++++++++++++ .../DumpRenderTree/mac/DumpRenderTreeWindow.h | 35 +++ .../DumpRenderTree/mac/DumpRenderTreeWindow.mm | 85 ++++++++ 7 files changed, 401 insertions(+), 224 deletions(-)
Created attachment 17427 [details] [PATCH] Abstract more of DRT into static methods WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm | 168 +++++++++++++--------- 1 files changed, 102 insertions(+), 66 deletions(-)
Comment on attachment 17426 [details] [PATCH] Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files +++ b/WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h \ No newline at end of file Add a new line. r=me
Comment on attachment 17427 [details] [PATCH] Abstract more of DRT into static methods You should make createCFURLFromPathOrURL static too. r=me
Landed (with your suggested changes) as r27941 and r27942