RESOLVED FIXED Bug 16074
execCommand("InsertHorizontalRule", false, "") results in id="" being inserted 
https://bugs.webkit.org/show_bug.cgi?id=16074
Summary execCommand("InsertHorizontalRule", false, "") results in id="" being inserted
Mark Rowe (bdash)
Reported 2007-11-20 12:35:55 PST
http://bdash.net.nz/files/arguments-combinations.html is a test case using InsertOrderedList rather than InsertHorizontalRule. You'll notice that a test is failing as InsertOrderedList does not insert id="" when the empty string is passed as the value argument. According to the HTML 5 specification an empty id attribute is not valid. I believe that InsertHorizontalRule should match InsertOrderedList/InsertUnorderedList on this point.
Attachments
Patch (3.71 KB, patch)
2007-11-20 12:41 PST, Mark Rowe (bdash) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2007-11-20 12:41:03 PST
Created attachment 17419 [details] Patch
Sam Weinig
Comment 2 2007-11-20 13:20:33 PST
Comment on attachment 17419 [details] Patch I think a test of InsertOrderedList and InsertUnorderedList with an empty string 3rd parameter would be nice if it doesn't already exist. r=me.
Mark Rowe (bdash)
Comment 3 2007-11-20 13:36:45 PST
Landed in r27931.
Note You need to log in before you can comment on or make changes to this bug.