Bug 16056 – Unicode not being interpreted correctly in Web Inspector source view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Dominic Mitchell]

Looking at this page, the Name: Αριστοτέλης Παγκαλτζής renders correctly.

If you look at that name in the DOM view of web inspector, it's correct.

However, if you look at the source code view of web inspector, it's wrong.  It looks like it's being shown as ISO-8859-1 instead of UTF-8.

This could be down to the page being application/xhtml+xml instead of text/html.

[Dominic Mitchell]

Created attachment 17407 [details]
Correctly rendered view of the page.

[Dominic Mitchell]

Created attachment 17408 [details]
Correctly rendered view in the DOM inspector.

[Dominic Mitchell]

Created attachment 17409 [details]
Incorrectly rendered in the source inspector.

[Alexey Proskuryakov]

Confirmed with r27834.

[Alexey Proskuryakov]

Created attachment 17420 [details]
proposed fix

[Adam Roben (:aroben)]

Comment on attachment 17420 [details]
proposed fix

+    if (resource->requestURL == resource->loader->requestURL()) {
         buffer = resource->loader->mainResourceData();
-    else {
+        textEncodingName = resource->loader->frame()->document()->inputEncoding();
+    } else {

Don't need braces here

+        virtual String encoding() const;

Can these methods return a const String&? Or are they returning transient Strings?

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> (From update of attachment 17420 [details] [edit])
> +    if (resource->requestURL == resource->loader->requestURL()) {
>          buffer = resource->loader->mainResourceData();
> -    else {
> +        textEncodingName =
> resource->loader->frame()->document()->inputEncoding();
> +    } else {
> 
> Don't need braces here

I think you DO need braces here.  :)

[Alexey Proskuryakov]

Committed revision 27937.

[Dominic Mitchell]

Wow!  Thanks for the quick attention!