Bug 16041 - REGRESSION: the Database panel in the Inspector stopped showing errors
Summary: REGRESSION: the Database panel in the Inspector stopped showing errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Timothy Hatcher
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2007-11-18 13:47 PST by Timothy Hatcher
Modified: 2007-11-18 18:40 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.52 KB, patch)
2007-11-18 13:50 PST, Timothy Hatcher
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2007-11-18 13:47:25 PST
With the new Database API the change to the Inspector code made it stop showing errors.
Comment 1 Timothy Hatcher 2007-11-18 13:50:52 PST
Created attachment 17369 [details]
Patch
Comment 2 Brady Eidson 2007-11-18 14:57:00 PST
Comment on attachment 17369 [details]
Patch

I wonder what the "The “%@”\ntable is empty." gobbledy-gook is about...  It comes up twice, but then later it seems %@ suffices in a similar situation.
If there's a good explanation then r=me
Comment 3 Timothy Hatcher 2007-11-18 15:01:53 PST
The patch doesn't show UTF-8 correctly, it is fine in the file.

Landed in r27892. http://trac.webkit.org/projects/webkit/changeset/27892
Comment 4 David Kilzer (:ddkilzer) 2007-11-18 18:32:06 PST
(In reply to comment #2)
> (From update of attachment 17369 [details] [edit])
> I wonder what the "The “%@”\ntable is empty." gobbledy-gook is about...  It
> comes up twice, but then later it seems %@ suffices in a similar situation.
> If there's a good explanation then r=me

(In reply to comment #3)
> The patch doesn't show UTF-8 correctly, it is fine in the file.

Could this be a format-string bug in patch?  What command did you use to create the patch, Tim?
Comment 5 Timothy Hatcher 2007-11-18 18:40:24 PST
I used svn-create-patch. Using svn diff gives me expected UTF-8.