Bug 16040 – [GTK] GtkLauncher should be written in C

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alp Toker]

Since our public API is C-only, the example code should be plain C, not C++.

It could do with a general cleanup as well.

[Alp Toker]

Created attachment 17365 [details]
Cleaned up C GtkLauncher, WIP

This is practically a rewrite, ported to C, using a toolbar instead of a menu, changing coding-style to something more common to C/GTK+ developers, and cleaning up old leftovers.

It still has globals. We can probably fix that later though.

[Alp Toker]

Created attachment 17367 [details]
Ported to C

Note that this patch does not attempt to fix all issues with the code.

[Alp Toker]

Created attachment 17368 [details]
Ported to C

Missed the ChangeLog in the previous patch.

[Holger Freyther]

(In reply to comment #3)
> Created an attachment (id=17368) [edit]
> Ported to C

IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't support it. If you want GtkLauncher to be portable you want to change the comments to be C comments.

[Alp Toker]

(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=17368) [edit]
> > Ported to C
> 
> IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't
> support it. If you want GtkLauncher to be portable you want to change the
> comments to be C comments.
> 

Noted. Will fix this up before landing.

[Mark Rowe (bdash)]

Comment on attachment 17368 [details]
Ported to C

r=me

[Alp Toker]

Landed in r27906.