Bug 16040 - [GTK] GtkLauncher should be written in C
Summary: [GTK] GtkLauncher should be written in C
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2007-11-18 09:44 PST by Alp Toker
Modified: 2007-11-19 07:59 PST (History)
0 users

See Also:


Attachments
Cleaned up C GtkLauncher, WIP (5.06 KB, text/plain)
2007-11-18 09:50 PST, Alp Toker
no flags Details
Ported to C (13.04 KB, patch)
2007-11-18 11:02 PST, Alp Toker
no flags Details | Formatted Diff | Diff
Ported to C (14.25 KB, patch)
2007-11-18 11:07 PST, Alp Toker
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-11-18 09:44:00 PST
Since our public API is C-only, the example code should be plain C, not C++.

It could do with a general cleanup as well.
Comment 1 Alp Toker 2007-11-18 09:50:20 PST
Created attachment 17365 [details]
Cleaned up C GtkLauncher, WIP

This is practically a rewrite, ported to C, using a toolbar instead of a menu, changing coding-style to something more common to C/GTK+ developers, and cleaning up old leftovers.

It still has globals. We can probably fix that later though.
Comment 2 Alp Toker 2007-11-18 11:02:50 PST
Created attachment 17367 [details]
Ported to C

Note that this patch does not attempt to fix all issues with the code.
Comment 3 Alp Toker 2007-11-18 11:07:08 PST
Created attachment 17368 [details]
Ported to C

Missed the ChangeLog in the previous patch.
Comment 4 Holger Freyther 2007-11-19 06:46:18 PST
(In reply to comment #3)
> Created an attachment (id=17368) [edit]
> Ported to C

IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't support it. If you want GtkLauncher to be portable you want to change the comments to be C comments.
Comment 5 Alp Toker 2007-11-19 07:01:15 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=17368) [edit]
> > Ported to C
> 
> IIRC the // comment was only introduced in C99. M$ Visual Studio doesn't
> support it. If you want GtkLauncher to be portable you want to change the
> comments to be C comments.
> 

Noted. Will fix this up before landing.
Comment 6 Mark Rowe (bdash) 2007-11-19 07:54:17 PST
Comment on attachment 17368 [details]
Ported to C

r=me
Comment 7 Alp Toker 2007-11-19 07:59:35 PST
Landed in r27906.