Bug 16032 - JS minidom is not portable
Summary: JS minidom is not portable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 16029
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-17 14:07 PST by Alp Toker
Modified: 2007-11-17 15:20 PST (History)
1 user (show)

See Also:


Attachments
Make minidom.c portable (2.02 KB, patch)
2007-11-17 14:33 PST, Alp Toker
darin: review+
Details | Formatted Diff | Diff
Make minidom.c portable (2.07 KB, patch)
2007-11-17 15:02 PST, Alp Toker
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-11-17 14:07:47 PST
JavaScriptCore/API/minidom.c is not portable. It has a trivial dependency on CFString and is missing a couple of includes.

JavaScriptCore.h also needs to be fixed as described in #16029 for this to actually build on non-CF platforms.
Comment 1 Alp Toker 2007-11-17 14:33:32 PST
Created attachment 17330 [details]
Make minidom.c portable

Note that it will not actually compile until JavaScriptCore.h is also fixed (see #16029)
Comment 2 Alp Toker 2007-11-17 15:02:24 PST
Created attachment 17331 [details]
Make minidom.c portable

This also fixes exception output which was being sent to stderr instead of stdout.
Comment 3 Eric Seidel (no email) 2007-11-17 15:05:29 PST
Comment on attachment 17331 [details]
Make minidom.c portable

Looks fine to me.  r=me.
Comment 4 Alp Toker 2007-11-17 15:15:21 PST
Landed in r27879.
Comment 5 Darin Adler 2007-11-17 15:20:35 PST
Comment on attachment 17330 [details]
Make minidom.c portable

Looks fine. It's going to be tricky to make this truly platform-independent though, because Mac OS X uses a special include style for frameworks (#include <JavaScriptCore/JavaScriptCore.h>), and I would not expect the library to work this way on other platforms.