Bug 15995 - Bring match() up-to-date with WebKit style guidelines in preparation for real hacking
Summary: Bring match() up-to-date with WebKit style guidelines in preparation for real...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-15 01:15 PST by Eric Seidel (no email)
Modified: 2007-11-15 16:15 PST (History)
0 users

See Also:


Attachments
the patch (ignoring whitespace) (57.52 KB, patch)
2007-11-15 01:15 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
patch (really ignoring whitespace) (51.92 KB, patch)
2007-11-15 01:17 PST, Eric Seidel (no email)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-11-15 01:15:13 PST
Bring match() up-to-date with WebKit style guidelines in preparation for real hacking

It's kinda sucky to do these white-space/style-update patches, but at least now the PCRE match() code is more readable to those accustomed to WebKit code.
Comment 1 Eric Seidel (no email) 2007-11-15 01:15:36 PST
Created attachment 17287 [details]
the patch (ignoring whitespace)
Comment 2 Eric Seidel (no email) 2007-11-15 01:17:15 PST
Created attachment 17288 [details]
patch (really ignoring whitespace)
Comment 3 Eric Seidel (no email) 2007-11-15 01:34:26 PST
Next on the chopping block is some of the needless gotos.  At least RETURN_ERROR can go right off the bat.
Comment 4 Sam Weinig 2007-11-15 10:17:39 PST
Comment on attachment 17288 [details]
patch (really ignoring whitespace)

Needs a changelog.

r=me
Comment 5 Eric Seidel (no email) 2007-11-15 16:15:02 PST
Landed.