Bug 15977 – match firefox's preference for resizing images

• Status: UNCONFIRMED
• Component: Images

[rahul abrol]

WebKitShrinksStandaloneImagesToFitKey (from bug 5400) is an all or none preference; setting it to 0 removes resizing altogether.

i suggest matching firefox's behavior, where the pref. controls whether the image is resized by default, but the option to resize via left-click is always present.

[rahul abrol]

Created attachment 17257 [details]
patch v1

simple patch.

[Mark Rowe (bdash)]

Can you please fill in the ChangeLog rather than leaving it empty.  Name, email address and a description of the change is required.

[rahul abrol]

Created attachment 17264 [details]
patch v1 w/better changelog

[Mark Rowe (bdash)]

Landed in r27903.

[rahul abrol]

i can't verify this.  safari 3.0.4 calls setShrinksStandaloneImagesToFit: which sets WebKitShrinksStandaloneImagesToFitKey to 1 on launch regardless of its previous value.

i don't understand this.  is setShrinksStandaloneImagesToFit: getting called with no parameter?

[rahul abrol]

r28200 undid this patch.
http://trac.webkit.org/projects/webkit/changeset/28200

if this was intentional, then "fixed" is the wrong resolution.

[Mark Rowe (bdash)]

Comment on attachment 17264 [details]
patch v1 w/better changelog

Clearing review flag since the patch was landed.

[Mark Rowe (bdash)]

Anders, can you comment on why <http://trac.webkit.org/projects/webkit/changeset/28200> reverted this behaviour?

[Anders Carlsson]

Because of backwards compatibility. There might be apps that rely on images not being autoresized, which is why we added the preference in the first place.

[Robert Blaut]

(In reply to comment #9)
> Because of backwards compatibility. There might be apps that rely on images not
> being autoresized, which is why we added the preference in the first place.
> 

So, is it impossible to fix the bug? If yes, it should be marked as WONTFIX.