WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 15924
next step in PCRE streamlining
https://bugs.webkit.org/show_bug.cgi?id=15924
Summary
next step in PCRE streamlining
Darin Adler
Reported
2007-11-09 10:58:04 PST
This is a 0.9% SunSpider speed-up.
Attachments
patch -- renames make it look *much* bigger than it is
(765.34 KB, patch)
2007-11-09 10:59 PST
,
Darin Adler
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2007-11-09 10:59:12 PST
Created
attachment 17158
[details]
patch -- renames make it look *much* bigger than it is
Sam Weinig
Comment 2
2007-11-09 18:08:29 PST
Comment on
attachment 17158
[details]
patch -- renames make it look *much* bigger than it is One typo. + (jsRegExpExecute): Use new/free instead of pcre_malloc/free. Removed unused + start_match field from the match block. You meant new/delete I believe. There is also one place where you use fastMalloc/fastFree instead of new/delete. I am not sure if you want to make the change. r=me. You may want to test on windows first though.
Darin Adler
Comment 3
2007-11-11 10:59:57 PST
Tested on Windows and made appropriate fixes. Committed revision 27686.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug