WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15915
add an evaluation path for booleans like the one we have for numbers
https://bugs.webkit.org/show_bug.cgi?id=15915
Summary
add an evaluation path for booleans like the one we have for numbers
Darin Adler
Reported
2007-11-08 22:42:48 PST
There are a lot of boolean expressions and the profile shows time being spent in jsBoolean
Attachments
patch
(49.43 KB, patch)
2007-11-08 22:57 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
improved patch
(54.73 KB, patch)
2007-11-09 08:48 PST
,
Darin Adler
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2007-11-08 22:57:43 PST
Created
attachment 17139
[details]
patch
Darin Adler
Comment 2
2007-11-09 08:48:02 PST
Created
attachment 17157
[details]
improved patch
Sam Weinig
Comment 3
2007-11-09 16:27:29 PST
Comment on
attachment 17157
[details]
improved patch My only comment would be that you might want to check if jsBoolean(true) and jsBoolean(false) compile down to a constant. Otherwise, r=me.
Darin Adler
Comment 4
2007-11-10 10:33:43 PST
Committed revision 27664.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug